523471 - stop running tiger talos tests on try builds that don't support tiger

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[alice nodelman [:alice] [:anode]]

Try tiger talos boxes have fallen way behind just doing reboot-busted tests-reboot cycles that aren't helping anyone.

Would need to be able to identify that a build would not run successfully on tiger and then not request to test there.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Perhaps we can grovel through the jar files to find where about:buildconfig is stored and look for "--with-macos-sdk=/Developer/SDKs/MacOSX10.4u.sdk" in the configure args. Dunno how much time we save if we do that on the talos slave.

Comment 2

[alice nodelman [:alice] [:anode]]

Patch currently baking on talos-staging.

Comment 3

[alice nodelman [:alice] [:anode]]

Attachment: don't run 10.5.sdk on 10.4 machines

Running on talos-staging-pool and talos-staging-try.  Short circuits test cycle if the sdk doesn't match the host platform.  Also reordered some factory steps so that we do this check as soon as possible.

Comment 4

[Chris AtLee [:catlee]]

Comment on attachment 408097 [details] [diff] [review]
don't run 10.5.sdk on 10.4 machines

Can you move the new class into a different file?  steps/misc.py is probably a good place.

Comment 5

[alice nodelman [:alice] [:anode]]

Attachment: don't run 10.5.sdk on 10.4 machines (take 2)

Comment 6

[alice nodelman [:alice] [:anode]]

Attachment: [checked in]don't run 10.5.sdk on 10.4 machines (take 3)

Better placement of added step class.

Comment 7

[alice nodelman [:alice] [:anode]]

Comment on attachment 408940 [details] [diff] [review]
[checked in]don't run 10.5.sdk on 10.4 machines (take 3)

changeset:   484:15a76058c83d

Comment 8

[alice nodelman [:alice] [:anode]]

Working on try now.