523475 - Developer Tools changes to support listed add-ons

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Justin Scott [:fligtar]]

Listed add-ons don't have access to all of the Developer Tools pages that hosted add-ons do, and some pages are slightly different.

The changes are as follows:

    *   Recent Activity
          o This page will be the same for both hosted and listed add-ons
    * Edit Add-on
          o Manage Authors
                + This page will be the same for both hosted and listed add-ons
          o Manage Categories
                + This page will be the same for both hosted and listed add-ons
          o Manage Tags
                + This page will be the same for both hosted and listed add-ons
          o Manage Add-on Descriptions
                + This page will be the same for both hosted and listed add-ons, except:
                + no EULA field is present
          o Manage Add-on Properties
                + This page will be the same for both hosted and listed add-ons, except:
                + the homepage field is required and is used as the main link
                + the View Source setting should not be displayed
                + application compatibility (applications and platforms) should be set here, using the same module that is normally on the Versions page.
          o Manage Developer Profile
                + This page will be the same for both hosted and listed add-ons
          o Manage Contributions
                + This page will not be available to listed add-ons
    * Change Status
          o This page will be the same for both hosted and listed add-ons
          o This page will have an option to change an add-on between hosted and listed status 
    * Statistics Dashboard
          o This page will not be available to listed add-ons
    * Versions and Files
          o This page will not be available to listed add-ons
    * Preview Screenshots
          o This page will be the same for both hosted and listed add-ons

For the homepage URL field, the description above the field should change to this for listed add-ons only:
"Enter the homepage URL of your add-on. Users will be directed to this location in order to download your add-on. You may <b>not</b> link directly to your add-on's file. Adding other translations is not necessary unless your website is localized into other languages."

The full spec is here: http://docs.google.com/Doc?id=dfntthnr_26gdrd3kfv

Comment 1

[Justin Scott [:fligtar]]

note: the Change Status page listed/hosted type swapping will be a separate bug.

Comment 2

[Fred Wenzel [:wenzel]]

In bug 523501 comment 13, clouserw points out a few things that we need to make sure are fixed for listed add-ons:

"
- On the "change status" page:  It says "Add-on Status" and is blank (there is
an "undefined index: 6" here).  [...]

- The "New Version" page appears to let me upload a new version?  Note the "New
version" link in the side bar and on /developers/addons

- I can add a new file to a version from /versions/edit/$version_id

- I shouldn't be able to delete "version 0" of my add-on.
"

Comment 3

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

I believe this addresses everything in this bug (both fligtars reqs and your notes from the other bug). Only difference is that I kept the versions page, where you can click on Version 0 und edit app compatibility and license.

If you feel strongly about it, I can make this functionality available on the "add-on properties" page, but I personally don't think that it hurts the way it is now. Let me know if you disagree.

Comment 4

[Wil Clouser [:clouserw]]

Comment on attachment 409138 [details] [diff] [review]
Patch, rev. 1

lots of good stuff

Comment 5

[Fred Wenzel [:wenzel]]

Thanks: r54618. I'll close this for now, but please reopen if anything is missing or if I need to change anything.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; we've been filing spin-off bugs on this since it landed.