523501 - Add-on submission changes for selecting listed type

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Justin Scott [:fligtar]]

We will need to change the first step of the add-on submission process to be selecting the add-on listing type.

Basic details are in the spec ( http://docs.google.com/Doc?id=dfntthnr_26gdrd3kfv&pli=1 )

It will involve:
* Presenting the user with a choice and explanation of each option
* If the user chooses to host their add-on on AMO, go to the current submission process
* If the user chooses only to list their add-on, we will need to collect some basic data, either through manual input or extraction from the install.rdf.

I will post copy and layout of this page tomorrow.

Comment 1

[Justin Scott [:fligtar]]

The text on the first page of the new add-on submission process should be changed to the following, in the style of the mockups in the spec.

----

Thanks for your interest in submitting your add-on to Mozilla Add-ons. We offer two types of listings, explained below. Both options are completely free for you and your users, so please choose the best fit for your needs.

Fully host my add-on on Mozilla Add-ons
Hosting your add-on on Mozilla Add-ons is the easiest way to handle distribution of your add-on. Your add-on will have a display page, appear in search and browse listings (including the Firefox and Thunderbird Add-ons Manager), and we'll take care of the download and automatic update process. Add-ons hosted on the site must be reviewed by a Mozilla Add-ons Editor before they will appear publicly.

[Let Mozilla host my add-on]

Self-host my add-on on my website
Submitting your self-hosted add-on allows you to publicize your creation in the official website for Mozilla-based add-ons, but lets you retain control of releases and file hosting. Add-ons that are only listed need not be approved by a Mozilla Add-ons Editor, but users will be warned that this review has not occurred.

[Self-host my add-on]

Need help deciding? [See a detailed comparison of your hosting options.]

Comment 2

[Fred Wenzel [:wenzel]]

Have any content for the listing comparison (and help on the right hand side)?

Comment 3

[Justin Scott [:fligtar]]

(In reply to comment #2)
> Have any content for the listing comparison (and help on the right hand side)?

I'm going to put all the comparison content in the separate page in bug 524239. I'm not sure what help on the right-hand side you mean.

Comment 4

[Fred Wenzel [:wenzel]]

(In reply to comment #3)
> I'm going to put all the comparison content in the separate page in bug 524239.

That works.

Comment 5

[Fred Wenzel [:wenzel]]

Do we need to ask for the add-on type too, or will they all just be ADDON_EXTENSION?

Comment 6

[Fred Wenzel [:wenzel]]

And while you're thinking about text snippets, do you mind coming up with a success message? The current one is:

"
Add-on Created!

Your add-on listing has been successfully created. The basic information has been stored, but there's a lot more to your listing that can be customized.

Your add-on is currently marked as Incomplete. In order to complete your add-on, you'll need to make sure it has an accurate name, summary, and description, as well as at least one selected category. You can edit your add-on's information using the link below and check the status of your add-on at any time on the status page.
-> Edit My Add-on
-> I'll complete my add-on later.
"

Comment 7

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

This is the first iteration. There are still a bunch of TODOs in there, so:

What works: Choosing what submission type to use; creating a listed add-on by entering the data asked for in the spec.

What's missing: The actual "need help deciding?" text; a useful success message; submitting an add-on to read the basic info from the manifest data.

All listed submissions are automatically ADDON_EXTENSION.

Comment 8

[Justin Scott [:fligtar]]

(In reply to comment #5)
> Do we need to ask for the add-on type too, or will they all just be
> ADDON_EXTENSION?

I think we should keep the same add-on type. They're still going to be extensions, themes, etc., just not hosted here. Although I would say we shouldn't allow self-hosted search engines.

For the success message text, I think if we just don't show the middle paragraph about being Incomplete, it still makes sense, as listed add-ons can still choose tags, categories, etc.

Comment 9

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 2

Second part of the patch. Makes it all a little prettier, updates the success message, and allows uploading an example .xpi file to derive the basic information from.

Comment 10

[Wil Clouser [:clouserw]]

I applied both patches, but I can't finish reviewing because they don't seem to work.  The notes I took up until I couldn't review:



- The headers on /addon/submit are clickable, but go nowhere.

- "Need help deciding? See a detailed comparison of your hosting options." link still goes nowhere.

- on /addon/submit, choose either option, then choose a license.  The "submit add-on" button never gets enabled.

- after choosing to self-host, if I click "Create listed add-on" with nothing, partially filled, or completely filled info, I see no errors and can't advance past this point

Comment 11

[Fred Wenzel [:wenzel]]

(In reply to comment #10)
> - The headers on /addon/submit are clickable, but go nowhere.

Those lead back to the submission possibility after you chose "compare options" before. Maybe I need to make them only clickable when they are collapsed.

> - "Need help deciding? See a detailed comparison of your hosting options." link
> still goes nowhere.

If this link doesn't do anything, there must be a JS error. Can you tell me what it is? Did both patches apply cleanly together? Let me attach a combined patch.

> - on /addon/submit, choose either option, then choose a license.  The "submit
> add-on" button never gets enabled.

Again, probably caused by a JS error before.

> - after choosing to self-host, if I click "Create listed add-on" with nothing,
> partially filled, or completely filled info, I see no errors and can't advance
> past this point

Yea, again, probably a JS error happening before, keeping the rest of the page from working.

Comment 12

[Fred Wenzel [:wenzel]]

Attachment: Same thing as one big patch

This is all I have and wfm here on the latest trunk.

Comment 13

[Wil Clouser [:clouserw]]

Comment on attachment 408990 [details] [diff] [review]
Same thing as one big patch

This works much better, but is definitely going to need a bunch of testing.  Things I noticed:

- On the "change status" page:  It says "Add-on Status" and is blank (there is an "undefined index: 6" here).  In the box below that, it says "Active Status: Active" even though I never made it active.  For non-listed add-ons we make the author flip that switch.

- The "New Version" page appears to let me upload a new version?  Note the "New version" link in the side bar and on /developers/addons

- I can add a new file to a version from /versions/edit/$version_id

- I chose a couple of compatible applications (firefox and fennec) but it ended up adding all the apps as compatible

- I chose Fx compatibility from 0.3 - 3.7a1pre but it didn't record it (or at least it didn't show it properly on /versions/edit/$version_id)

- There is no feedback as to what fields are incorrect when submitting the intial form.  I had a malformed URL but all it said was "an error occured"

- I shouldn't be able to delete "version 0" of my add-on.

Comment 14

[Fred Wenzel [:wenzel]]

Thanks, these are helpful comments -- though I am not sure most of them are in-scope for the submission process. I'll make sure to remember them in bug 523475, though.

I'll look into the app versions problem and will make sure to specify more exactly what error occurred, if I can do so without rewriting the entire developers controller ;)

Comment 15

[Fred Wenzel [:wenzel]]

(In reply to comment #13)
> - On the "change status" page:  It says "Add-on Status" and is blank (there is
> an "undefined index: 6" here).  In the box below that, it says "Active Status:
> Active" even though I never made it active.  For non-listed add-ons we make the
> author flip that switch.

O RLY? I don't think we need to put an extra step in between there for listed add-ons, but I may be wrong. All add-ons are "active" when they are created, hosted ones are just STATUS_INCOMPLETE. Since we use the status field to mark an add-on LISTED, we cannot mark it incomplete also. So I could, if that's what we wanted, mark listed add-ons author-disabled from the get-go, and let them manually enable it. But that will differ from hosted add-ons that have to change the add-on's status instead.

Comment 16

[Fred Wenzel [:wenzel]]

I've committed the current state to r54538 and r54539.

Comment 17

[Wil Clouser [:clouserw]]

(In reply to comment #15)
> (In reply to comment #13)
> > - On the "change status" page:  It says "Add-on Status" and is blank (there is
> > an "undefined index: 6" here).  In the box below that, it says "Active Status:
> > Active" even though I never made it active.  For non-listed add-ons we make the
> > author flip that switch.
> 
> O RLY? I don't think we need to put an extra step in between there for listed
> add-ons, but I may be wrong. All add-ons are "active" when they are created,
> hosted ones are just STATUS_INCOMPLETE. Since we use the status field to mark
> an add-on LISTED, we cannot mark it incomplete also. So I could, if that's what
> we wanted, mark listed add-ons author-disabled from the get-go, and let them
> manually enable it. But that will differ from hosted add-ons that have to
> change the add-on's status instead.

Ah, right.  Let's try it without marking them disabled and see how it goes.

Comment 18

[Fred Wenzel [:wenzel]]

(In reply to comment #14)
> I'll look into the app versions problem and will make sure to specify more
> exactly what error occurred, if I can do so without rewriting the entire
> developers controller ;)

r54548.

I'm done so far for this bug. I'll check with fligtar if I need to remove the comparison list on the first page.

Comment 19

[Jeff Balogh (:jbalogh)]

I tried alternative 2 for listed addons with http://mattconstantine.com/minimalistgmail.xpi, but it says: "The add-on failed a validation test: No install.rdf present."  The add-on has an install.rdf.  Is this option working for you?  It could be a problem with my environment.

Comment 20

[Fred Wenzel [:wenzel]]

Yes, it's working for me. Do you have NETAPP_STORAGE defined? I think that's where files get extracted to (but I am not sure, off the top of my head).

Comment 21

[Fred Wenzel [:wenzel]]

(In reply to comment #20)
> Yes, it's working for me.

FWIW, I just re-confirmed that it works by trying out the .xpi file you pointed out. So it's probably indeed a missing option in your config. Thanks for testing this though, Jeff!

Comment 22

[Fred Wenzel [:wenzel]]

I removed the comparison table from the submission page: r54657. This bug is closed, but please reopen if there are any problems.

Comment 23

[Jeff Balogh (:jbalogh)]

(In reply to comment #21)
> (In reply to comment #20)
> > Yes, it's working for me.
> 
> FWIW, I just re-confirmed that it works by trying out the .xpi file you pointed
> out. So it's probably indeed a missing option in your config. Thanks for
> testing this though, Jeff!

It worked after I *chmod*'d NETAPP_STORAGE to 777.  Check it, davedash!

Comment 24

[Vishal Kamdar [:vish_moz]]

Verified, FIXED.

Comment 25

[Vishal Kamdar [:vish_moz]]

Filed  Bug 527833 related to addon submission form for listed addons.