Closed Bug 523565 Opened 15 years ago Closed 15 years ago

nsHTMLLabelAccessible shouldn't be text accessible

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

Attached patch patchSplinter Review
this bug is part of bug 372131.

nsHTMLLabelAccessible should be inherited from hyper text accessible.

1) it's not text accessible therefore nsTextAccessible::AppendTextTo is called never for label accessible.
2) linkable/traverse state go from linkable accessible stuffs, this is not needed any more since only text accessibles can be true linkable accessibles (bug 372131).
Attachment #407505 - Flags: review?(bolterbugz)
Comment on attachment 407505 [details] [diff] [review]
patch

r=me assuming we already have test coverage of this code. Thanks.

(Probably still good to check with NVDA -- at least a ping -- but don't hold on this)
Attachment #407505 - Flags: review?(bolterbugz) → review+
(In reply to comment #1)
> (From update of attachment 407505 [details] [diff] [review])
> r=me assuming we already have test coverage of this code. Thanks.

I think we don't have tests for this. Actually nothing to test I think.

> (Probably still good to check with NVDA -- at least a ping -- but don't hold on
> this)

Jamie, I think it should be safe for NVDA since it removes old MSAA-related hacks, HTML label doesn't implement ISimpleDOMText any more and it doesn't inherit link states and actions if the label is placed as a child of a link. I don't think you depend on this.
landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/7f1f309a34f8
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: