add download source tracking for install service

VERIFIED FIXED in 5.3

Status

addons.mozilla.org Graveyard
Administration
P3
normal
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: fligtar, Assigned: fligtar)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
The install service should accept a src parameter that it passes to the file download URL so that these add-ons can use source tracking too.

So, https://addons.mozilla.org/services/install.php?addon_id=personas&src=external-getpersonas should add the src param to the xpi URL.
(Assignee)

Comment 1

9 years ago
And if there is no src= parameter set, let's default to src=installservice and we'll need to add that as an allowed src in the db and add copy to the sources page:

From Install Service
Downloads passed through the AMO Install Service are counted here.
Summary: src parameter should trickle down install service → add download source tracking for install service
(Assignee)

Comment 2

9 years ago
Created attachment 408750 [details] [diff] [review]
patch, v1

Really want this in 5.3 so doing it myself!
Assignee: nobody → fligtar
Status: NEW → ASSIGNED
Attachment #408750 - Flags: review?(clouserw)
(Assignee)

Updated

9 years ago
Attachment #408750 - Attachment is patch: true
Attachment #408750 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 408750 [details] [diff] [review]
patch, v1

You might want to explain what the AMO Install Service is.
Attachment #408750 - Flags: review?(clouserw) → review+
(Assignee)

Comment 4

9 years ago
I was intentionally vague as its existence is not well-known. I may add a little more detail.
(Assignee)

Comment 5

9 years ago
r54493
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: push-needed
Resolution: --- → FIXED
(Assignee)

Comment 6

9 years ago
I forgot to do SQL for this bug!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 7

9 years ago
eh, I'll just do it in bug 526600
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED
Verified, as this is being tracked/verified in bug 526600.
Status: RESOLVED → VERIFIED
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.