523740 - about:firstrun is shown *every* time Fennec starts

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Al Billings [:abillings - ex-MoCo]]

The first time you run Fennec, it is supposed to show the page, about:firstrun. Right now, it shows the page every time Fennec starts instead.

Found in the 10/21 1.9.2 build on OS X.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

We should just port the needHomePageOverride logic from Firefox.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This also fixes bug 448718 by showing the awesome bar on non-first-runs. Need to evaluate the perf impact of that...

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 410313 [details] [diff] [review]
patch

>     this.addTab(whereURI, true);
>+    if (whereURI == "about:blank")
>+      BrowserUI.showAutoComplete();

We could use BrowserUI.newTab, but this is easier and less overhead

Comment 4

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mobile-browser/rev/717d75cb7e0d

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Windows; U; Window3sCE 5.2; en-US; rv:1.9.2b4pre) Gecko/20091116 Namoroka/3.6b4pre Fennec/1.0a4pre

and

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b3pre) Gecko/20091116 Firefox/3.6b4pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091116 Firefox/3.7a1pre Fennec/1.0b5

Comment 6

[Aakash Desai [:aakashd]]

Litmus testcase https://litmus.mozilla.org/show_test.cgi?id=9763 has been created to regression test this bug.

Comment 7

[Tim Samoff]

The patch was submitted on 11/04/2009, but this is still occurring in 1.0b5. Is there an ETA on when it will be released?

Comment 8

[:Gavin Sharp [email: [e-mail]]]

It's fixed in nightly builds, and it will be fixed in the next release (1.0 RC 1).