Closed Bug 523740 Opened 13 years ago Closed 13 years ago

about:firstrun is shown *every* time Fennec starts

Categories

(Firefox for Android Graveyard :: General, defect)

Fennec 1.1
defect
Not set
normal

Tracking

(fennec1.0+)

VERIFIED FIXED
fennec1.0
Tracking Status
fennec 1.0+ ---

People

(Reporter: abillings, Assigned: Gavin)

References

Details

Attachments

(1 file)

The first time you run Fennec, it is supposed to show the page, about:firstrun. Right now, it shows the page every time Fennec starts instead.

Found in the 10/21 1.9.2 build on OS X.
tracking-fennec: --- → ?
We should just port the needHomePageOverride logic from Firefox.
Assignee: nobody → gavin.sharp
Attached patch patchSplinter Review
This also fixes bug 448718 by showing the awesome bar on non-first-runs. Need to evaluate the perf impact of that...
OS: Mac OS X → All
Hardware: x86 → All
tracking-fennec: ? → 1.0+
Attachment #410313 - Flags: review?(mark.finkle)
Comment on attachment 410313 [details] [diff] [review]
patch

>     this.addTab(whereURI, true);
>+    if (whereURI == "about:blank")
>+      BrowserUI.showAutoComplete();

We could use BrowserUI.newTab, but this is easier and less overhead
Attachment #410313 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mobile-browser/rev/717d75cb7e0d
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Post-B5
verified FIXED on builds:

Mozilla/5.0 (Windows; U; Window3sCE 5.2; en-US; rv:1.9.2b4pre) Gecko/20091116 Namoroka/3.6b4pre Fennec/1.0a4pre

and

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b3pre) Gecko/20091116 Firefox/3.6b4pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091116 Firefox/3.7a1pre Fennec/1.0b5
Status: RESOLVED → VERIFIED
Flags: in-litmus?
Litmus testcase https://litmus.mozilla.org/show_test.cgi?id=9763 has been created to regression test this bug.
Flags: in-litmus? → in-litmus+
The patch was submitted on 11/04/2009, but this is still occurring in 1.0b5. Is there an ETA on when it will be released?
It's fixed in nightly builds, and it will be fixed in the next release (1.0 RC 1).
You need to log in before you can comment on or make changes to this bug.