523803 - Star Icon used in Message list pane is too big

Status: RESOLVED FIXED

Description

[Valery Kondakoff]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.5pre) Gecko/20091021 Shredder/3.0pre

Star Icon used in Message list pane is too big and does not fit in the column (I can not resize the column  width by draggin it's borders with mouse). See the screenshot.

I think the size of the star in message list columns should match the size of the star in the column header.

Reproducible: Always

Comment 1

[Valery Kondakoff]

Attachment: Screenshot of message list pane with the big Star icon

Comment 2

[[:Aureliano Buendía]]

I don't agree.

Comment 3

[Valery Kondakoff]

The Star icon should fit into the column width. Thus the icon size should be
reduced, or there should be a way to change the width of the column.

Comment 4

[[:Aureliano Buendía]]

set to New because Andreas has assigned to him

Comment 5

[Valery Kondakoff]

I just mentioned the Star icon, because right now it does not fit into column width. But take a look at the other icons (attach and spam). Attach icon size matches the size of column header icon. Spam and Star icons does not match the size of columns headers icons.

This looks rather ugly. Just made all the icons equal size and made it fit to the column size.

Comment 6

[Valery Kondakoff]

Attachment: Spam, Star and Attach icons of different size

Comment 7

[Bryan Clark (DevTools PM) [:clarkbw]]

the spam icon looks fine to me but somehow our star icon has lost the space it needed.  Did this one not get changed to the smaller star icon?  marking as blocking polish for andreas

Comment 8

[[:Aureliano Buendía]]

Attachment: Windows Media Center Royale Theme

I know that isn't this the right place (but I admit about theme refactoring I did not understand much: e.g bug #506011 is closed but has various issue etc) it seems that using the royale theme (the default theme in Windows Media Center, I use an version for Windows XP) the icon on message list are misalligned as in attached sceenshot. 
But probably it's better open a new bug, but I'm not on Windows Media Center... we have a very Windows Media Center user that can test this?

Comment 9

[Andreas Nilsson (:andreasn)]

Attachment: fix for linux, xp and vista

Comment 10

[Thomas Stache]

It's curious that the screenshot in attachment 381857 [details] of bug 496642 clearly shows a wider star column. Was the size intentionally decreased since summer?

Comment 11

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 408357 [details] [diff] [review]
fix for linux, xp and vista

Tried this on Vista so far and it looks good.  Will do a check on Linux later but from looking at the files I think it will be very similar.

Comment 12

[Phil Ringnalda (:philor)]

Comment on attachment 408357 [details] [diff] [review]
fix for linux, xp and vista

Linux is fine, and my XP build finally finished and is fine too.

Comment 13

[Mark Banner (:standard8)]

Checked in:
http://hg.mozilla.org/comm-central/rev/a3da2f2e37ac
http://hg.mozilla.org/releases/comm-1.9.1/rev/3d923f9323f4