XHR not taken from visible window when runtime's window is hidden

RESOLVED FIXED in 0.6

Status

P1
normal
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: adw, Assigned: adw)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 407799 [details] [diff] [review]
patch

|xhr| is set once in the |Extension.isHidden| conditional but then immediately set again outside the conditional.  Probably you just forget the else.

I noticed this when I was testing Twitter in 3.6 and trunk on OS X.  The XHR's authentication prompt doesn't appear on the main window.  It floats by itself and is only visible via Expose, and the result is that Firefox appears locked up.  Interestingly, on 3.5 the prompt does appear on the main window, which is probably why this wasn't caught sooner.
Attachment #407799 - Flags: review?(avarma)

Comment 1

9 years ago
Thanks! Pushed in rev e382b1895f12.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Attachment #407799 - Flags: review?(avarma)
You need to log in before you can comment on or make changes to this bug.