Closed
Bug 523919
Opened 15 years ago
Closed 15 years ago
BreakpadVendor string localization not working
Categories
(Camino Graveyard :: Translations, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino2.0
People
(Reporter: etguler, Assigned: stuart.morgan+bugzilla)
Details
(Whiteboard: [camino-2.0])
Attachments
(2 files)
|
1.51 KB,
patch
|
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
|
55.97 KB,
image/png
|
Details |
This "en-blunt" localization is too good to disappear into the ether
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; tr; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; tr; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 The BreakpadVendor string from InfoPlist.strings file doesn't appear in target language. It appears in Crash Reporter window. But as you can see from the screenshot, it's still English. To view screenshot: http://i35.tinypic.com/j8p02f.jpg Reproducible: Always Steps to Reproduce: 1. Make Camino crashed 2. 3.
We need to see if other languages can reproduce this, or if it's just limited to languages that don't have a Mac OS X localization, and then see what we can do.
Flags: camino2.0?
Summary: BreakpadVendor string localization → BreakpadVendor string localization not working
|
Assignee | |
Comment 2•15 years ago
|
||
Oh, I bet know what's going on here. We're passing Breakpad the infoDictionary return value, but that doesn't do automagic localization. This should be easy to fix.
Assignee: nobody → stuart.morgan+bugzilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: camino2.0? → camino2.0+
Target Milestone: --- → Camino2.0
|
||
Comment 3•15 years ago
|
||
Confirmed for Italian. I have also opened the Italian InfoPlist.strings translation and the string is translated.
Flags: camino2.0+ → camino2.0?
Re-plussing since somehow Marcello accidentally clobbered the flag ;)
Flags: camino2.0? → camino2.0+
|
|
Assignee | |
Comment 6•15 years ago
|
||
Grab the localized vendor.
Attachment #407864 -
Flags: superreview?(mikepinkerton)
|
||
Comment 8•15 years ago
|
||
Comment on attachment 407864 [details] [diff] [review] fix sr=pink
Attachment #407864 -
Flags: superreview?(mikepinkerton) → superreview+
|
|
Assignee | |
Comment 9•15 years ago
|
||
Landed on CVS trunk and CAMINO_2_0_BRANCH.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [camino-2.0]
|
||
Comment 10•15 years ago
|
||
Will this fix be in the RC?
Yes.
You need to log in
before you can comment on or make changes to this bug.
Description
•