523944 - Default favicon not shown for non-existent or broken favicons anymore

Status: RESOLVED WORKSFORME

(Core :: Graphics: ImageLib, defect)

Description

[Sylvain Pasche]

If you view a page that uses a broken favicon (an empty file or something that isn't an image), no favicon is shown at all instead of using the default favicon. As a result, there is a gap on the left of the tab title and address bar which looks not so nice.

To reproduce, start with a clean profile and open one of these these URLs. They are all referencing an empty favicon:
http://software.hixie.ch/utilities/js/live-dom-viewer/
http://timecapsuledead.org/
http://www.w3.org/Bugs/Public/query.cgi

If you reload the page, the default favicon appears so that's only an issue the first time the page loads.

Regression range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ff3496b1f6c7&tochange=bf0fdec8f43b

I guess that this is a regression from bug 435296.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It's not only for broken favicons. Also sites without a favicon show an empty area now, e.g. attachment 387537 [details].

Comment 3

[Daniel Holbert [:dholbert]]

This site reproduces this issue, the first time it's loaded after restarting Firefox (no need for clean profile):  https://services.mozilla.com/

Comment 4

[Gary [:streetwolf52]]

I came across this site and wonder if it's the same bug.  Favicon is empty everywhere it can be found with d2d/dw enabled.  The icon is GIF.

http://www.softexia.com/    

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a3pre) Gecko/20100307 Minefield/3.7a3pre - Build ID: 20100307041909

Comment 5

[Bobby Holley (:bholley)]

I can't reproduce this. Can someone confirm that it's still broken on trunk?

Comment 6

[Daniel Holbert [:dholbert]]

WFM on Ubuntu, using all URLs reported so far, with current m-c nightly.
Mozilla/5.0 (X11; Linux i686; rv:2.0b3pre) Gecko/20100802 Minefield/4.0b3pre

Also verified that it was still broken in an old build, for the attachment linked in comment 1. (the other sites seem to have fixed their favicons)
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20091110 Minefield/3.7a1pre

So, resolving as WORKSFORME.  (feel free to change to FIXED & update dependency list if you know what fixed it)