523951 - Don't dirty the persistence flag for size/position on every NS_ACTIVATE

Status: NEW

(Core :: XUL, defect, P3)

Description

[Nochum Sossonko [:Natch]]

Currently every time we get an NS_ACTIVATE message we re-persist all the attributes on the <window> element. This is unnecessary, and detrimental in the case of bug 509828 comment 35.

Comment 1

[Nochum Sossonko [:Natch]]

So, Neil informed me that the reason we do this is to ensure persistence of the last available window. Thing is, if you have two windows and resize one, then close it, you'd want to persist the second window's size, hence the need to dirty the persistence flag.

I'm still looking into a good solution for this.

Comment 2

[Boris Zbarsky [:bzbarsky]]

> Thing is, if you have two windows and resize one, then close it, you'd want to
> persist the second window's size

Personally, I rely on this NOT being the case.  It means I can temporarily resize one of my browser windows to better fit the content in it, without the browser forgetting the window size I actually prefer.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Er, maybe I'm agreeing with you.  Not sure.  I think I described my use case accurately, though.

Comment 4

[Nochum Sossonko [:Natch]]

Yes, it's one and the same.

Comment 5

[Nochum Sossonko [:Natch]]

So, just doing this on window close should be just fine since the values aren't persisted anyhow until window close, one way or the other (at least afaik).

That would make it:

1) With 1 window open, open another.
2) Resize the 2nd window.
3) Close that window.
4) Size values are persisted from the second window.
5) Close the first window, the size values will be persisted from the 1st window.

Comment 6

[Nochum Sossonko [:Natch]]

(In reply to comment #5)
Hmm, actually the difference would be that windows opened between steps 3 and 4 will be the size of the second window as opposed to the first window, just tested that. I'll have to look into another way to do what's needed for bug 509828 comment 35.

Comment 7

[Nochum Sossonko [:Natch]]

Pushing out old bugs that I won't have time to actually get to. Feel free to use/extend any patches attached...

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information