Closed Bug 523956 Opened 15 years ago Closed 15 years ago

NJ merge: codealloc and arm drift

Categories

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect, P2)

Product:
Tamarin Graveyard
Component:
Baseline JIT (CodegenLIR)
Platform:
ARM
All
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
flash10.1

People

(Reporter: graydon, Assigned: rreitmai)

References

Details

Attachments

(1 file, 1 obsolete file)

aaaaand refreshed to your tip
3.15 KB, patch
Details | Diff | Splinter Review 
Minor bits from tracemonkey, just trying desperately to get to "no deltas".
Status: NEW → ASSIGNED
Priority: -- → P2
Hardware: All → ARM
Target Milestone: --- → flash10.1
I love how I keep failing to attach patches. Classy. Will update this when I get in.
Attached patch sorry 'bout that (obsolete) — — Splinter Review 

    
    

    
  


  

        Attachment #408030 -
        Attachment is obsolete: true

    
    

    
  
pushed http://hg.mozilla.org/tamarin-redux/rev/9d0caa7cacdd

with the following caveats:
(1) rejected the codealloc change as it doesn't compile on wince
(2) NativeARM.h changes rejected, since the existing ifdef are needed for tamarin compiles.  Can you accept as is?  I don't believe they will cause issues, but if so let's figure out a cleaner way of enabling these constants.

    
  
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
    

    
  
Oh duh, the CodeAlloc change takes a pointer-ref not a pointer. Silly me.

    
  
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: