52399 - *BSD needs to define GiveSytemInfo in unix_rand.c to compile NSS 3.1

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Thomas Stromberg]

build breaks in FreeBSD 5.0 for NSS 3.1 because GiveSystemInfo, GetHighResClock,
etc. are not defined in unix_rand.c. The guilty line is line 79:

#if defined(SCO) || defined(UNIXWARE) || defined(BSDI)

which should be || defined(BSD)

build breakage follows:


-L../../../../dist/FreeBSD5.0_OPT.OBJ/lib/ -lplc4 -lplds4 -lnspr4  -lc_r
/usr/lib/libc.so: WARNING!  setkey(3) not present in the system!
/usr/lib/libc.so: warning: this program uses gets(), which is unsafe.
/usr/lib/libc.so: WARNING!  des_setkey(3) not present in the system!
/usr/lib/libc.so: WARNING!  encrypt(3) not present in the system!
/usr/lib/libc.so: warning: tmpnam() possibly used unsafely; consider using
mkstemp()
/usr/lib/libc.so: warning: this program uses f_prealloc(), which is stupid.
/usr/lib/libc.so: WARNING!  des_cipher(3) not present in the system!
/usr/lib/libc.so: warning: tempnam() possibly used unsafely; consider using
mkstemp()
../../../../dist/FreeBSD5.0_OPT.OBJ/lib/libsecutil.a(sysrand.o): In function
RNG_GetNoise':
sysrand.o(.text+0x6d): undefined reference to GetHighResClock'
../../../../dist/FreeBSD5.0_OPT.OBJ/lib/libsecutil.a(sysrand.o): In function
RNG_SystemInfoForRNG':
sysrand.o(.text+0x371): undefined reference to GiveSystemInfo'
sysrand.o(.text+0x462): undefined reference to GiveSystemInfo'
gmake[2]: *** [FreeBSD5.0_OPT.OBJ/certcgi] Error 1
gmake[2]: Leaving directory
/usr/src/moz-crypto/mozilla/security/nss/cmd/certcgi'
gmake[1]: *** [libs] Error 2
gmake[1]: Leaving directory /usr/src/moz-crypto/mozilla/security/nss/cmd'

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch. Added || defined(FREEBSD).

Comment 2

[Wan-Teh Chang]

The patch is checked into rev. 1.3 of
mozilla/security/nss/lib/util/unix_rand.c.