Template Hook for attachment creating and editing, at end

RESOLVED FIXED in Bugzilla 3.6

Status

()

Bugzilla
Extensions
--
enhancement
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Max Kanat-Alexander, Assigned: Max Kanat-Alexander)

Tracking

Bugzilla 3.6
Bug Flags:
approval +

Details

(Whiteboard: [es-ita])

Attachments

(1 attachment, 1 obsolete attachment)

v2
656 bytes, patch
Max Kanat-Alexander
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
Created attachment 407956 [details] [diff] [review]
v1

Here's a template hook for attachment/create, after the table is created. (I'm using it to insert some JavaScript.)

This is a super-simple one-line patch.
Attachment #407956 - Flags: review?(dkl)
(Assignee)

Updated

8 years ago
Whiteboard: [es-ita]
(Assignee)

Updated

8 years ago
Summary: Template Hook for attachment/create.html.tmpl, after table → Template Hook for attachment creating and editing, at end
(Assignee)

Comment 1

8 years ago
Created attachment 407960 [details] [diff] [review]
v2

I renamed it to "end" to be more consistent and I also added one for the editing form.
Assignee: ui → mkanat
Attachment #407956 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #407960 - Flags: review?(dkl)
Attachment #407956 - Flags: review?(dkl)

Comment 2

8 years ago
This patch is going to conflict with my (large) patch from bug 365267. I would like my patch to land first. It's much more painful to unbitrot it than this one.
(Assignee)

Comment 3

8 years ago
(In reply to comment #2)
> This patch is going to conflict with my (large) patch from bug 365267. I would
> like my patch to land first. It's much more painful to unbitrot it than this
> one.

  Fair enough, I can wait. :-)
(Assignee)

Comment 4

8 years ago
Comment on attachment 407960 [details] [diff] [review]
v2

Granting myself review as module owner, though I may have to un-bitrot this patch.
Attachment #407960 - Flags: review?(dkl) → review+
(Assignee)

Updated

8 years ago
Flags: approval3.4+
Flags: approval+
(Assignee)

Updated

8 years ago
Flags: approval3.4+ → approval3.4?
(Assignee)

Updated

8 years ago
Component: User Interface → Extensions
(Assignee)

Comment 5

8 years ago
Actually, it surprisingly applied, with just a fuzz. :-)

Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.45; previous revision: 1.44
done
Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.64; previous revision: 1.63
done
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Target Milestone: Bugzilla 3.4 → Bugzilla 3.6

Comment 6

8 years ago
I guess you forgot to remove the approval3.4? flag, per the target milestone.
Flags: approval3.4?
You need to log in before you can comment on or make changes to this bug.