524065 - Template Hook for attachment creating and editing, at end

Status: RESOLVED FIXED

(Bugzilla :: Extensions, enhancement)

Description

[Max Kanat-Alexander]

Attachment: v1

Here's a template hook for attachment/create, after the table is created. (I'm using it to insert some JavaScript.)

This is a super-simple one-line patch.

Comment 1

[Max Kanat-Alexander]

Attachment: v2

I renamed it to "end" to be more consistent and I also added one for the editing form.

Comment 2

[Frédéric Buclin]

This patch is going to conflict with my (large) patch from bug 365267. I would like my patch to land first. It's much more painful to unbitrot it than this one.

Comment 3

[Max Kanat-Alexander]

(In reply to comment #2)
> This patch is going to conflict with my (large) patch from bug 365267. I would
> like my patch to land first. It's much more painful to unbitrot it than this
> one.

  Fair enough, I can wait. :-)

Comment 4

[Max Kanat-Alexander]

Comment on attachment 407960 [details] [diff] [review]
v2

Granting myself review as module owner, though I may have to un-bitrot this patch.

Comment 5

[Max Kanat-Alexander]

Actually, it surprisingly applied, with just a fuzz. :-)

Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.45; previous revision: 1.44
done
Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.64; previous revision: 1.63
done

Comment 6

[Frédéric Buclin]

I guess you forgot to remove the approval3.4? flag, per the target milestone.