524106 - "View Image Info" shows wrong data of image when there are images of same src=url in a document

Status: VERIFIED FIXED

(Firefox :: Page Info Window, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2b2pre) Gecko/20091022 Firefox/3.5.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091022 Minefield/3.7a1pre ID:20091022234402

"View Image Info" shows  wrong data of image when there are images of same src=url in a document.

Reproducible: Always

Steps to Reproduce:
1.Start Minefield with new Profile
2.Open Test Case
3.Carry out a "View Image Info" command in image B
Actual Results:  
The result displays wrong data
Dimensions:       128px × 128px (scaled to 80px × 80px)
Associated Text:Minefield icon 80px

Expected Results:  
The result should be as follows
Dimensions:       128px × 128px (scaled to 200px × 200px)
Associated Text:Minefield icon 200px

Comment 1

[Alice0775 White]

Attachment: testcase

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

Comment 3

[Tanner M. Young [:tmyoung]]

I will leave it to db48x for the official review, but FWIW, I quickly went over the patch (since I wrote what you had to fix ;) ), and it looks good to me.

Comment 4

[Tanner M. Young [:tmyoung]]

The new testcase for Bug 517902 will be broken by this since it looks for the image src not the element, and I can't use the element until this is fixed, so if the testcase is added, I am happy to provide a patch to make it compatible with this.

Dao: What would you like?

Comment 5

[Dão Gottwald [:dao]]

Adding a knowingly broken test for knowingly broken code doesn't make sense to me, so I'd rather do it once this is fixed.

Comment 6

[Tanner M. Young [:tmyoung]]

Mconnor wanted the test and it was conditional on this the feature committed but the test took longer than we had anticipated.  If he or beltzner would like to wait on the test for this patch, I'm more than happy to do so.  If they do not, I will gladly fix both the testcase and this patch, so that you don't need to be bothered with all of this.

Comment 7

[Daniel Brooks [:db48x]]

Comment on attachment 408005 [details] [diff] [review]
patch

r=db48x

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/ac98fd60de44

Comment 9

[Tanner M. Young [:tmyoung]]

Verified Fixed on trunk.

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091030 Minefield/3.7a1pre (.NET CLR 3.5.30729) ID:20091030060356

Comment 10

[Tanner M. Young [:tmyoung]]

Requesting in-testsuite.  The testcase for Bug 517902 should cover this.

Comment 11

[Tanner M. Young [:tmyoung]]

I am granting in-testsuite, since the testcase for Bug 517902 covers this: correct?

Comment 12

[Dão Gottwald [:dao]]

yep

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 408005 [details] [diff] [review]
patch

a192=beltzner

Comment 14

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/a75bfb26ac49