Closed Bug 524106 Opened 12 years ago Closed 12 years ago
"View Image Info" shows wrong data of image when there are images of same src=url in a document
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2b2pre) Gecko/20091022 Firefox/3.5.1 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091022 Minefield/3.7a1pre ID:20091022234402 "View Image Info" shows wrong data of image when there are images of same src=url in a document. Reproducible: Always Steps to Reproduce: 1.Start Minefield with new Profile 2.Open Test Case 3.Carry out a "View Image Info" command in image B Actual Results: The result displays wrong data Dimensions: 128px × 128px (scaled to 80px × 80px) Associated Text:Minefield icon 80px Expected Results: The result should be as follows Dimensions: 128px × 128px (scaled to 200px × 200px) Associated Text:Minefield icon 200px
Summary: "View Image Info" shows wrong data of image When there is an image of same SRC in a document → "View Image Info" shows wrong data of image when there are images of same src=url in a document
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows Vista → All
Hardware: x86 → All
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #408005 - Flags: review?(db48x)
Component: Menus → Page Info
QA Contact: menus → page.info
I will leave it to db48x for the official review, but FWIW, I quickly went over the patch (since I wrote what you had to fix ;) ), and it looks good to me.
The new testcase for Bug 517902 will be broken by this since it looks for the image src not the element, and I can't use the element until this is fixed, so if the testcase is added, I am happy to provide a patch to make it compatible with this. Dao: What would you like?
Adding a knowingly broken test for knowingly broken code doesn't make sense to me, so I'd rather do it once this is fixed.
Mconnor wanted the test and it was conditional on this the feature committed but the test took longer than we had anticipated. If he or beltzner would like to wait on the test for this patch, I'm more than happy to do so. If they do not, I will gladly fix both the testcase and this patch, so that you don't need to be bothered with all of this.
Comment on attachment 408005 [details] [diff] [review] patch r=db48x
Attachment #408005 - Flags: review?(db48x) → review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Verified Fixed on trunk. Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091030 Minefield/3.7a1pre (.NET CLR 3.5.30729) ID:20091030060356
Status: RESOLVED → VERIFIED
Requesting in-testsuite. The testcase for Bug 517902 should cover this.
I am granting in-testsuite, since the testcase for Bug 517902 covers this: correct?
Flags: in-testsuite? → in-testsuite+
Comment on attachment 408005 [details] [diff] [review] patch a192=beltzner
Attachment #408005 - Flags: approval1.9.2? → approval1.9.2+
You need to log in before you can comment on or make changes to this bug.