524123 - [Regression] Opening tabs in background fails to render into tiles

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

When opening a tab in the background, the tab thumbnail is created and rendered correctly, but the main tile area is not rendered. Pressing "refresh" will cause the tiles to render.

The page is obviously loaded correctly, just not rendered.

To reproduce, go to http://popuptest.com so the popups open in the background. Or use the new (not landed at time of filing bug) Open in Tab feature (bug 465284)

Comment 1

[Benjamin Stover (:stechz)]

It looks like we've had this problem a long time.  See _resizeAndPaint.

>    if (this == Browser.selectedTab) {
>      // !!! --- RESIZE HACK BEGIN -----
>      bv.simulateMozAfterSizeChange();
>      // !!! --- RESIZE HACK END -----
>
>      let restoringPage = (this._state != null);
>
>      if (!this._browserViewportState.zoomChanged && !restoringPage) {
>        // Only fit page if user hasn't started zooming around and this is a page that
>        // isn't being restored.
>        bv.zoomToPage();
>      }
>    }

The code needed to correctly size the viewport and set up zooming is specific to the current browser.  When it's in the background, we simply don't set things up so the browser view is still (0, 0, 1, 1) (you can see a pixel being rendered).

The patch here isn't tough, but I bet my lunch it'd be wasted effort when the patch for bug 480958 lands.  Adding as a dep.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

http://hg.mozilla.org/mobile-browser/rev/3d8f7d7b2fc7 from bug 480958 fixed this

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b2pre) Gecko/20091104 Firefox/3.6b2pre Fennec/1.0b5

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091104 Firefox/3.7a1pre Fennec/1.0b5