Closed Bug 524216 Opened 13 years ago Closed 13 years ago

Support 'gre-resources' as an alias on 1.9.2

Categories

(Firefox Build System :: General, enhancement)

1.9.2 Branch
enhancement
Not set
normal

Tracking

(status1.9.2 beta3-fixed)

RESOLVED FIXED
mozilla1.9.2
Tracking Status
status1.9.2 --- beta3-fixed

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

Attachments

(1 file)

... to ease non m-c applications to migrate from m-1.9.1 to m-1.9.2/m-c.
Flags: in-testsuite-
(In reply to comment #0)
> ... to ease non m-c applications to migrate from m-1.9.1 to m-1.9.2/m-c.

why not try land the gre-resources patches on 192?
(In reply to comment #1)
> why not try land the gre-resources patches on 192?

Obviously ... You'd better ask people involved in those bugs and branch...

In any case, this bug could land as a temporary workaround (so I can move my c-c patches forward) in the meantime.
(In reply to comment #3)
> (In reply to comment #1)
> > why not try land the gre-resources patches on 192?
> 
> Obviously ... You'd better ask people involved in those bugs and branch...
> 
> In any case, this bug could land as a temporary workaround (so I can move my
> c-c patches forward) in the meantime.

I am just a little worried about this fallback approach leading to perf problems in the long term. I'd be ok if this alias had an expiration date or something that would gurantee that we would use it forever.
Attachment #408127 - Flags: review?(neil) → review+
Comment on attachment 408127 [details] [diff] [review]
(Av1) Just alias it
[Checkin: Comment 12]

"approval1.9.2=?":
No risk, will help comm-central.
Attachment #408127 - Flags: approval1.9.2?
(In reply to comment #4)

> I am just a little worried about this fallback approach leading to perf
> problems in the long term.

Hopefully, the perf impact is very low.
Moreover, one can continue to use the old/native syntax if one prefers.

> I'd be ok if this alias had an expiration date or
> something that would gurantee that we would use it forever.

It's m-1.9.2 specific, thus guaranteed to expire when that branch does.
(And m-1.9.2 is not aimed to be long-lived for all we know now.)
IMHO the much better solution would be to have done the alias in a comm-central jar.mn.

The *only* reason it is difficult to patch for 1.9.2 for comm-central apps is the fact that we haven't got a branch. Non-comm-central apps are likely to be able to cope with it in a much better way and then we're also not polluting mozilla-central with unnecessary items.

(In reply to comment #3)
> (In reply to comment #1)
> > why not try land the gre-resources patches on 192?
> 
> Obviously ... You'd better ask people involved in those bugs and branch...

It would perhaps have been nice to at least investigate the possibilities with a quick question first.
(In reply to comment #7)

> IMHO the much better solution would be to have done the alias in a comm-central
> jar.mn.

Iiuc, this would mean duplicating it in each c-c app.

> Non-comm-central apps are likely to be
> able to cope with it in a much better way and then we're also not polluting
> mozilla-central with unnecessary items.

I assumed some other apps might just be in the same case...
I thought it best to fix it at the source, at least to ask for that first.

> (In reply to comment #3)
> > Obviously ... You'd better ask people involved in those bugs and branch...
> 
> It would perhaps have been nice to at least investigate the possibilities with
> a quick question first.

(My previous answer stands :-|)
Taras, ping for approval1.9.2:
my synchronization work on c-c depends on having (or not) this alias in m-1.9.2.
(In reply to comment #9)
> Taras, ping for approval1.9.2:
> my synchronization work on c-c depends on having (or not) this alias in
> m-1.9.2.

I don't think I have approval powers for this. I agree with this change, but I think it's up to 192 drivers to approve this.
Flags: blocking1.9.2?
Comment on attachment 408127 [details] [diff] [review]
(Av1) Just alias it
[Checkin: Comment 12]

a192=beltzner
Attachment #408127 - Flags: approval1.9.2? → approval1.9.2+
Comment on attachment 408127 [details] [diff] [review]
(Av1) Just alias it
[Checkin: Comment 12]


http://hg.mozilla.org/releases/mozilla-1.9.2/rev/8641b5d60989
Attachment #408127 - Attachment description: (Av1) Just alias it → (Av1) Just alias it [Checkin: Comment 12]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: blocking1.9.2?
Resolution: --- → FIXED
Depends on: 533255
Blocks: 533255
No longer depends on: 533255
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.