524254 - The comment box in bug/edit.html.tmpl should be a block

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Max Kanat-Alexander]

The only major piece of code in bug/edit.html.tmpl that's not in a BLOCK is the Additional Comments section. I've frequently wanted to have it in a block during customizations, and I've now run into an upstream situation where it would be much easier to refactor the file if that code were in a block, so I'm breaking this off into its own bug and just doing it.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay, here we go! When I created the comment_box block, I moved the actual comments.html.tmpl outside of it. As a result, some new CSS was needed for it. Also, the <hr>'s were no longer the same size as the comments. Instead of getting very complicated with the HTML and CSS structure of the bug edit page, I just moved the Collapse/Expand links to be on the right of the comments, which is nice because there's usually a bunch of extra space there anyway.

I will attach some screenshots.

Comment 2

[Max Kanat-Alexander]

Attachment: Screenshot: Logged In

Here's what it looks like under Dusk when you are logged in.

Comment 3

[Max Kanat-Alexander]

Attachment: Screenshot: Logged Out

And here's what it looks like when you're logged out.

Both of these are at 1024x768, by the way.

Comment 4

[Max Kanat-Alexander]

Oh, also, by the way, the taking of the comments out of the comment-box table is also necessary for my work on bug 524251.

Comment 5

[Frédéric Buclin]

Sometimes, lines can be long because replies are never wrapped (as expected). In this case, the two links you added on the right may reach the right side of the page. What happens to them in that case, i.e., how do they look like when they wrap?

Also, I visually prefer to have them where they are now, even with HR going away. pyrzak?

Comment 6

[Max Kanat-Alexander]

The simply collapse a bit. It's a table. Try applying the patch and just making the window smaller.

Comment 7

[Frédéric Buclin]

Comment on attachment 408174 [details] [diff] [review]
v1

>Index: template/en/default/bug/edit.html.tmpl

>+    [% PROCESS bug/comments.html.tmpl
>+      comments = bug.longdescs
>+      mode = user.id ? "edit" : "show"
>+    %]

>-        [% PROCESS bug/comments.html.tmpl
>-           comments = bug.longdescs
>-           mode = user.id ? "edit" : "show"
>-         %]

The patch bitrots due to bug 472217. At both places above, you have to write bug.comments instead of bug.longdescs. r=LpSolit with this change.

Comment 8

[Frédéric Buclin]

Comment on attachment 408174 [details] [diff] [review]
v1

>Index: template/en/default/bug/edit.html.tmpl

>+        [% Hook.process("after_comment_textarea") %]

Err... wait. This line being in a BLOCK now generates errors in the web server log:

show_bug.cgi: Use of uninitialized value $template_name in concatenation (.) or string at Bugzilla/Template/Plugin/Hook.pm line 60.
show_bug.cgi: Use of uninitialized value $type in concatenation (.) or string at Bugzilla/Template/Plugin/Hook.pm line 60.

Line 60 of Hook.pm is:
  my $extension_template = "$path$template_name-$hook_name.$type.tmpl";


This reminds me a bug where a hook in a BLOCK was having issues about not knowing where it is exactly.

Comment 9

[Max Kanat-Alexander]

Attachment: v2

Okay, this fixes the bitrot and the Hook problem. The workaround right now for hooks in blocks is to actually specify the template name as the second argument to Hook.process().

Comment 10

[Frédéric Buclin]

Comment on attachment 417393 [details] [diff] [review]
v2

r=LpSolit

Comment 11

[Max Kanat-Alexander]

Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.71; previous revision: 1.70
done
Checking in template/en/default/bug/comments.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/comments.html.tmpl,v  <--  comments.html.tmpl
new revision: 1.46; previous revision: 1.45
done
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.172; previous revision: 1.171
done

Comment 12

[Max Kanat-Alexander]

Added to the release notes in bug 547466.