Beginning on October 25th, 2016, Persona will no longer be an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 524271 - Compilation Error AIX filepicker component
: Compilation Error AIX filepicker component
source dir moved strip dirs for patch...
: fixed1.9.0.16, regression
Product: Toolkit
Classification: Components
Component: XUL Widgets (show other bugs)
: unspecified
: PowerPC AIX
: -- normal (vote)
: ---
Assigned To: Uli Link (:ul-mcamafia)
: Neil Deakin
: 537556 (view as bug list)
Depends on: 497838
Blocks: 507758 537556 537588
  Show dependency treegraph
Reported: 2009-10-24 05:21 PDT by Uli Link (:ul-mcamafia)
Modified: 2010-01-03 05:51 PST (History)
7 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch for compilation on AIX (4.71 KB, patch)
2009-10-26 00:17 PDT, Uli Link (:ul-mcamafia)
jwalden+bmo: review+
roc: superreview+
dveditz: approval1.9.1.6+
dveditz: approval1.9.0.16+
Details | Diff | Splinter Review

Description Uli Link (:ul-mcamafia) 2009-10-24 05:21:38 PDT
User-Agent:       Mozilla/5.0 (X11; U; AIX 5.1; en-US; rv: Gecko/20091019 SeaMonkey/1.1.18
Build Identifier: FIREFOX_3_0_15_RELEASE

Building deps for /home/ulink/Src/mozilla/xpfe/components/filepicker/src/nsWildCard.cpp
"/home/ulink/Src/mozilla/xpfe/components/filepicker/src/nsWildCard.cpp", line 449.20: 1540-0274 (S) The name lookup for "ns_WildCardMatch" did not find a declaration.
"/home/ulink/Src/mozilla/xpfe/components/filepicker/src/nsWildCard.cpp", line 449.20: 1540-1292 (I) Static declarations are not considered for a function call if the function is not qualified.
"/home/ulink/Src/mozilla/xpfe/components/filepicker/src/nsWildCard.cpp", line 442.1: 1540-0700 (I) The previous message was produced while processing "NS_WildCardMatch_<unsigned short>(const unsigned short *, const unsigned short *, PRBool)".
"/home/ulink/Src/mozilla/xpfe/components/filepicker/src/nsWildCard.cpp", line 457.12: 1540-0700 (I) The previous message was produced while processing "NS_WildCardMatch(const PRUnichar *, const PRUnichar *, PRBool)".
gmake[2]: *** [nsWildCard.o] Error 1
gmake[2]: Leaving directory `/home/ulink/Src/AIX-51/fx3/xpfe/components/filepicker/src'
gmake[1]: *** [libs] Error 2
gmake[1]: Leaving directory `/home/ulink/Src/AIX-51/fx3/xpfe/components/filepicker'
gmake: *** [default] Error 2

Reproducible: Always

Steps to Reproduce:
1. Compile on AIX with Visual C++ 6.0 or IBM XLC/C++ 7.0

Actual Results:  
Compilation error

Expected Results:  
Successful compilation

No problem with compiling filepicker component before 3.0.15
Comment 1 Uli Link (:ul-mcamafia) 2009-10-24 05:28:45 PDT
Regression of bug 507758
Comment 2 Uli Link (:ul-mcamafia) 2009-10-26 00:17:52 PDT
Created attachment 408335 [details] [diff] [review]
Patch for compilation on AIX
Comment 3 Jeff Walden [:Waldo] (remove +bmo to email) 2009-10-26 17:55:35 PDT
Comment on attachment 408335 [details] [diff] [review]
Patch for compilation on AIX

It's unfortunate some compilers don't understand this, but oh well...
Comment 4 Uli Link (:ul-mcamafia) 2009-10-27 00:50:41 PDT
Comment on attachment 408335 [details] [diff] [review]
Patch for compilation on AIX

Applies only to 1.9.0 and 1.9.1 branches
Comment 5 Uli Link (:ul-mcamafia) 2009-10-27 01:10:21 PDT
Duplicate for other branches of bug 497838
Comment 6 Daniel Veditz [:dveditz] 2009-10-30 11:58:37 PDT
Comment on attachment 408335 [details] [diff] [review]
Patch for compilation on AIX

Approved for and, a=dveditz for release-drivers
Comment 7 Daniel Veditz [:dveditz] 2009-11-11 00:37:33 PST
Checking in xpfe/components/filepicker/src/nsWildCard.cpp;
/cvsroot/mozilla/xpfe/components/filepicker/src/nsWildCard.cpp,v  <--  nsWildCard.cpp
new revision: 1.6; previous revision: 1.5
Comment 8 Daniel Veditz [:dveditz] 2009-11-11 01:06:49 PST

Is there anything remaining to do on trunk or is this bug FIXED now?
Comment 9 Uli Link (:ul-mcamafia) 2009-11-11 01:39:38 PST
Newer branches and trunk are fixed by bug 497838
So nothing todo on AIX for filepicker.
Comment 10 Phil Ringnalda (:philor) 2010-01-02 17:51:29 PST
*** Bug 537556 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.