524284 - Text not visible after pressing enter in a <span>

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Sylvain Pasche]

Click on the URL for the testcase. If you press enter in a line that is contained in an inline element, the text you type next is not visible. However, that text is still inserted in the DOM.

Another testcase using Midas:
1) open http://www.mozilla.org/editor/midasdemo/
2) set font to Arial
3) press enter
4) type some text
Result: the text you type is not visible.

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

this regressed within
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7b0e65cf4226&tochange=d3298de30066

Comment 2

[Simon Montagu :smontagu]

Local backout shows that this is a regression from bug 504524

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Minimal-ish testcase

Comment 4

[Boris Zbarsky [:bzbarsky]]

Frame tree before the .data set:

    Block(body)(1)@0x1409140 {480,480,35640,2304} [state=00100000] sc=0x1409028(i=2,b=0)<
      line 0x1409548: count=1 state=inline,clean,prevmarginclean,not impacted,not wrapped,before:nobr,after:linebr[0xa140] {0,0,1,1152} <
        Inline(span)(0)@0x14094a8 next=0x1409720 next-continuation=0x1409720 {0,96,1,960} [content=0x151112b0] [overflow=0,-96,1,1152] [sc=0x1409080]<
          Frame(br)(0)@0x14094e8 {0,-96,1,1152} [content=0x151155a0]
        >
        Overflow-list<
          Text(1)@0x1409c20[0,0,T]  {0,0,0,0} [state=00000402] [content=0x1519d020] sc=0x14085e0 pst=:-moz-non-element<
            ""
          >
        >
      >
      line 0x1409760: count=1 state=inline,clean,prevmarginclean,not impacted,not wrapped,before:nobr,after:linebr[0xa100] {0,1152,1,1152} <
        Inline(span)(0)@0x1409720 prev-continuation=0x14094a8 {0,1248,1,960} [state=00000004] [content=0x151112b0] [overflow=0,-96,1,1152] [sc=0x1409080]<
          Frame(br)(2)@0x1409518 {0,-96,1,1152} [content=0x151128c0]
        >
      >
    >

Frame tree after the .data set and a reflow:

          Block(body)(1)@0x1409140 {480,480,35640,2304} [state=00100000] sc=0x1409028(i=2,b=0)<
            line 0x1409548: count=1 state=inline,clean,prevmarginclean,not impacted,not wrapped,before:nobr,after:linebr[0xa140] {0,0,1,1152} <
              Inline(span)(0)@0x14094a8 next=0x1409720 next-continuation=0x1409720 {0,96,1,960} [content=0x151112b0] [overflow=0,-96,1,1152] [sc=0x1409080]<
                Frame(br)(0)@0x14094e8 {0,-96,1,1152} [content=0x151155a0]
              >
              Overflow-list<
                Text(1)@0x1409c20[0,1,T]  {0,0,0,0} [state=00000402] [content=0x1519d020] sc=0x14085e0 pst=:-moz-non-element<
                  "a"
                >
              >
            >
            line 0x1409760: count=1 state=inline,clean,prevmarginclean,not impacted,not wrapped,before:nobr,after:linebr[0xa100] {0,1152,1,1152} <
              Inline(span)(0)@0x1409720 prev-continuation=0x14094a8 {0,1248,1,960} [state=00000004] [content=0x151112b0] [overflow=0,-96,1,1152] [sc=0x1409080]<
                Frame(br)(2)@0x1409518 {0,-96,1,1152} [content=0x151128c0]
              >
            >
          >
        >

Why do we have that text frame hanging out on the overflow list?  Why isn't the inline on the next line pulling it?  For the case when we set .data, we don't even mark the next line dirty, that I can see....

Comment 5

[Boris Zbarsky [:bzbarsky]]

The patch for bug 523468 fixes this.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Fixed by checkin of bug 523468.