52429 - char send warning needs new wording

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Henrik Gemal]

if you compose a mail that contains chars that cant be recoded into the chosen 
Char coding, you'll get an warning. The warning text is not very good.
The dialog seems to be modular to the 3pane window and not the compose window, 
and since the warning talks about "this message" it's hard for the user to 
uderstand which message that we talk about.

Comment 1

[Henrik Gemal]

Attachment: Diff to fix wording of warning

Comment 2

[Jean-Francois Ducarroz]

reassign to nhotta

Comment 3

[nhottanscp]

Sorry to take a while before looking at this.
The change looks fine for me.
It would be better if this could be reviewed by Kat Momoi who is out for several 
weeks.
Adding tao and rchen since this will affect localization projects.
Is that still okay to change strings in .dtd?

Comment 4

[nhottanscp]

I contacted our L10N team and it's okay to check in as long as this is checked 
in today. Please contact mozilla.org to get an approval.
Also adding Vera for an extra review.

Comment 5

[verah (gone)]

Please change to:

"The message you composed contains characters not found in the selected 
Character Coding, so your recipient may not be able to read it. To send it 
anyway, click OK. To return to the dialog box where you can choose a different 
Character Coding, click Cancel."

This is simpler and more standard. Thanks!

Comment 6

[Henrik Gemal]

Attachment: Diff to include verah text

Comment 7

[nhottanscp]

It looks good, r=nhotta. Henrik, please get an approval from mozilla.org. Do you 
have checkin privilege?

Comment 8

[Michele Carlson]

Please do not make this change. It is too late to make a change to the localized 
Japanese product.
thanks 

Comment 9

[Jaime Rodriguez, Jr.]

NHotta/Henrik - 

Please Note:This bug does not have an [nsbetta3++] status, hence the change can 
not be checked in until after PR3 is released.  It is also P3, which means it is 
low priority. Please do not check-in changes which affect text and the UI.

Comment 10

[Jaime Rodriguez, Jr.]

Adding Cindy to cc: list.

Comment 11

[Katsuhiko Momoi]

Sorry, I was not able to look at this bug until now.
Looks like this will be a future bug to fix. In anticipation
of that time, let me make a suggestion on the wording verah
wrote in above.

"The message you composed contains characters not found in the selected
Character Coding, so your recipient may not be able to read it. To send it
anyway, click OK. To return to the dialog box where you can choose a different
Character Coding, click Cancel."

What is **the dialog box** one can return to? If you choose "Cancel", you return to
the Composer window from which you clicked on the "Send" button. I suggest a slight
change in wording as follows:

"The message you composed contains characters not found in the selected
Character Coding, so your recipient may not be able to read it. To send it
anyway, click OK. To return to the Composer window where you can choose a
different Character Coding, click Cancel."

Comment 12

[verah (gone)]

Kat's wording change looks fine to me.

Comment 13

[nhottanscp]

Henrik, could you create a new patch and get review/approval?

Comment 14

[Henrik Gemal]

Attachment: Newest diff that include Kats wording

Comment 15

[nhottanscp]

r=nhotta

Comment 16

[Henrik Gemal]

I dont have cvs acess or anything, so what are the steps to checkin this fix?

Comment 17

[Alec Flett]

sr=alecf

Comment 18

[nhottanscp]

Checked in to the trunk.

Comment 19

[nhottanscp]

Fixed in the trunk.

Comment 20

[Jaime Rodriguez, Jr.]

Adding jenm to cc: list.

Comment 21

[nhottanscp]

fixed in trunk

Comment 22

[Jaime Rodriguez, Jr.]

removing myself.

Comment 23

[Henrik Gemal]

verifying bugs...
build 2001013020