524302 - "Update Now" text doesn't match button label

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[timeless]

steps:
1. enable at least one out of date plugin, I chose "QuickTime Plug-in 7.6.2" (which is odd, since my macbook pro runs 10.5.8, but whatever)
2. visit http://www.mozilla.com/en-US/plugincheck/

expected results:
instructions and available buttons should match

actual results:
# Click Update Now to update a plugin.

QuickTime Plug-in 7.6.2
The QuickTime Plugin allows you to view a wide variety of multimedia content in web pages. For more information, visit the QuickTime Web site. 	Outdated Version 	Update

note that "Update Now" and "Update" are not the same.

Comment 1

[timeless]

Attachment: patch

note that i'm unlikely to do the commit myself...

Comment 2

[Steven Garrity [:sgarrity]]

Looking at the JS code (/js/plugincheck.js) that builds the buttons on this page, there is one button that is labelled "Update" and another that is updated "Update Now". I'm not sure why the inconsistency.

CC'ing Austin King for some background.

Comment 3

[Austin King [:ozten]]

(In reply to comment #2)
If a plugin is out of date then it's button says "Update".
If a plugin is out of date and there is a known vulnerability for that version, then it says "Update Now".

Comment 4

[Steven Garrity [:sgarrity]]

Comment on attachment 408222 [details] [diff] [review]
patch

Review of attachment 408222 [details] [diff] [review]:
-----------------------------------------------------------------

Fixed elsewhere. Thanks.