524327 - [10.6] Hoefler Text css font crashes Firefox 3.5.3 on Snow Leopard

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect)

Description

[Robert Sayre]

http://twitter.com/jchris/status/5135877463

I guess this page was crashing firefox when it contained the relevant CSS:

http://jchrisa.net/drl/_design/sofa/_show/post/HTML5-Storage-Continues

Comment 1

[Jonathan Kew [:jfkthame]]

If someone running Snow Leopard - I haven't made the jump yet - could try this and get us a stack for the crash (assuming it's reproducible), I'd appreciate it.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I wonder whether it's http://crash-stats.mozilla.com/report/list?product=Firefox&query_search=signature&query_type=exact&query=&date=&range_value=1&range_unit=weeks&do_query=1&signature=TLWFNType1Font%3A%3ATLWFNType1Font%28TResourceForkSurrogate%20const%26%2C%20TResourceFileDataSurrogate%20const%26%2C%20TResourceFileDataSurrogate%20const%26%29 which is a 10.6-only crash I noticed in crash-stats.

Comment 3

[Jonathan Kew [:jfkthame]]

That sounds an unlikely candidate, judging by the function signature TLWFNType1Font::TLWFNType1Font(....). That looks like it would be handling old "classic-style" LWFN printer font resources. Hoefler Text on 10.6 is packaged as a .ttc (TrueType Collection) file, I believe; in 10.5 it was .dfont. It's never been shipped in LWFN form, AFAIK.

Comment 4

[John Daggett (:jtd)]

Distilled testcase based on the HTML5 storage page in the description.  Crashes 1.9.1.x, 1.9.2 but not trunk which must be using CoreText.  Setting gfx.force_atsui_text on to true on trunk makes the problem occur on trunk also.  Does not crash on 10.5.

Comment 5

[John Daggett (:jtd)]

CoreText is doing some wacky stuff too, the text "Our goal original goal is for the spec" is rendered as "Our goal original goal is ffkor the spec".  Copying and pasting this text displays correctly.  Safari also renders the text correctly.

Comment 6

[John Daggett (:jtd)]

0  ATS ProcessSingleMorphRun  	
1  ATS ProcessMorphActionList 	
2  ATS ApplyMorphForRun 	
3  ATS ApplyMorph 	
4  ATS _eLLCLayoutText 	
5  ATS LLCLayoutText 	
6  QD  ATSULayoutGlyphs 	
7  QD  TTextLineLayout::LayoutGlyphVector 	
8  QD  TTextLineLayout::EnsureLayoutIsUpToDate 	
9  QD  TTextLineLayout::GetGlyphBounds 	
10 QD  ATSUGetGlyphBounds 	
11 XUL gfxAtsuiFontGroup::InitTextRun 	gfx/thebes/src/gfxAtsuiFonts.cpp:1539
12 XUL gfxAtsuiFontGroup::MakeTextRun 	gfx/thebes/src/gfxAtsuiFonts.cpp:781
13 XUL TextRunWordCache::MakeTextRun 	gfx/thebes/src/gfxTextRunWordCache.cpp:807
14 XUL gfxTextRunWordCache::MakeTextRun 	gfx/thebes/src/gfxTextRunWordCache.cpp:1003
15 XUL BuildTextRunsScanner::BuildTextRunForFrames 	layout/generic/nsTextFrameThebes.cpp:461
16 XUL BuildTextRunsScanner::FlushFrames 	layout/generic/nsTextFrameThebes.cpp:1230

Comment 8

[John Daggett (:jtd)]

Apple bug in ATSUI code. Fixed in 10.6.2.  Testcase renders fine on 3.5.x, 1.9.2 and trunk code with gfx.force_atsui_text set to true.

Comment 9

[Robert Sayre]

(In reply to comment #5)
> CoreText is doing some wacky stuff too, the text "Our goal original goal is for
> the spec" is rendered as "Our goal original goal is ffkor the spec".  Copying
> and pasting this text displays correctly.  Safari also renders the text
> correctly.

Is there a bug on the CoreText problem, or is that also fixed in 10.6.2?

Comment 10

[John Daggett (:jtd)]

Looks like the font itself was updated in 10.6.2:

Hoefler Text; 6.1d7e1; 2009-09-21

Will test with original font to make sure ATSUI code has been fixed.

Comment 11

[John Daggett (:jtd)]

(In reply to comment #9)
> Is there a bug on the CoreText problem, or is that also fixed in 10.6.2?

Yup, trunk code on 10.6.2 renders without the problems noted in comment 5.

Comment 12

[John Daggett (:jtd)]

Hoefler Text version that shipped in initial 10.6 release:
Hoefler Text; 6.1d6e1; 2009-05-06