Closed Bug 524349 Opened 10 years ago Closed 10 years ago

Port |Bug 517417 - access violation: while compiling xulrunner tries to test for Mercurial repositories above its build dir| to comm-central

Categories

(MailNews Core :: Build Config, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.1a1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Flags: in-testsuite-
Attachment #408266 - Flags: review?(bugzilla)
Attachment #408266 - Flags: review?(bugzilla) → review+
Comment on attachment 408266 [details] [diff] [review]
(Av1) Just port it
[Checkin: Comment 2]


http://hg.mozilla.org/comm-central/rev/19730ac448e3


"approval-thunderbird3=?":
No risk, safer command.
Attachment #408266 - Attachment description: (Av1) Just port it → (Av1) Just port it [Checkin: Comment 2]
Attachment #408266 - Flags: approval-thunderbird3?
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1a1
Comment on attachment 408266 [details] [diff] [review]
(Av1) Just port it
[Checkin: Comment 2]

I don't think we need to take this on 1.9.1 especially as mozilla-1.9.1 hasn't got the equivalent either so it won't actually be better in any way.
Attachment #408266 - Flags: approval-thunderbird3? → approval-thunderbird3-
Depends on: 515792
(untested) trivial copy of m-c patch.

*****

PS: None of these 2 bugs landed on m-1.9.2, but that should not cause any trouble.
Attachment #418584 - Flags: review?(bugzilla)
(In reply to comment #4)
> Created an attachment (id=418584) [details]
> (Bv1) Port bug 515792 too

What has that got to do with this bug apart from a mild association? This bug was fixed over a month ago, can we stop doing additional patches in RESOLVED bugs please.
Blocks: 536136
No longer depends on: 515792
Attachment #418584 - Attachment description: (Bv1) Port bug 515792 too → (Bv1) Port bug 515792 too [Moved to bug 536136]
Attachment #418584 - Attachment is obsolete: true
Attachment #418584 - Flags: review?(bugzilla)
(In reply to comment #5)

I filed bug 536136.
You need to log in before you can comment on or make changes to this bug.