Closed Bug 524356 Opened 15 years ago Closed 15 years ago

Update build scripts that use the socketserver to fail gracefully

Categories

(Tamarin Graveyard :: Tools, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: brbaker, Assigned: brbaker)

Details

Attachments

(1 obsolete file)

There are a handful of scripts in the build system that use the socketserver on ASTEAM to log results. These scripts currently will block and die if the socketserver is down, and therefore fail the build.

These scripts should be updated to not fail if the socketserver is not available, but instead print out a warning that can be shown in the build system.

Known scripts:
- utils/sizereport.py
- test/performance/runtests.py
Flags: in-testsuite-
Flags: flashplayer-triage+
Attached patch patch (obsolete) — Splinter Review
Attachment #408273 - Flags: review?(dschaffe)
Comment on attachment 408273 [details] [diff] [review]
patch

we may want to print the results message regardless of failure or not.  It is easy to manually add results to the socket server.  we should signal a warning on failure so we can see the orange indication the socket server failed.
Attachment #408273 - Flags: review?(dschaffe) → review+
Comment on attachment 408273 [details] [diff] [review]
patch

Pushed changeset:   2872:65d942c631f8

- sizereport.py prints out the msg that would have been sent if there is a failure so it can be manually sent if needed
- updated both scripts to print out the 'buildbot_status: WARNINGS' so that it will appear as a warning in the build system
Attachment #408273 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: