524395 - Boolean charts And, Or, "add another chart" buttons do no work with JS turned off

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Guy Pyrzak]

To reproduce
1. Turn off Javascript
2. Go to query.cgi advanced search
3. Try using the and, or or add another charts buttons on the boolean charts
4. Notice it submits the query instead of adding a chart.

Comment 1

[Frédéric Buclin]

I know what's going on. buglist.cgi is looking for &cmd- to decide if it should redirect the user to query.cgi (when JS is turned on, buglist.cgi is not called, as JS does the trick itself), but it can happen that cmd- is the first param in the URL, and so is not prepended by & but by ?. A more robust check is to loop over CGI params and redirect to query.cgi if it detects one param starting with cmd-.

Comment 2

[Frédéric Buclin]

I found what regressed this: bug 15809, which landed on the 3.4 branch. As it removes unused params, it now happens that cmd-add is the first param in the URL, and so is not prepended by & anymore.

Comment 3

[Max Kanat-Alexander]

Yeah, just grep { $_ =~ /something/ } $cgi->param()

Comment 4

[Frédéric Buclin]

Attachment: patch, v1

I moved the check much higher in buglist.cgi, as first implemented in 2000 by Terry. We indeed don't want to do all the other stuff when all we want to do is to add another boolean chart.

Comment 5

[Max Kanat-Alexander]

Comment on attachment 408296 [details] [diff] [review]
patch, v1

Looks reasonable to me.

Comment 6

[Frédéric Buclin]

tip:

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.405; previous revision: 1.404
done

3.4.2:

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.394.2.6; previous revision: 1.394.2.5
done