Closed Bug 524413 Opened 11 years ago Closed 11 years ago

re-enable the flash plugin

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
blocker

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dougt, Assigned: dougt)

References

Details

(Keywords: relnote)

Attachments

(1 file, 1 obsolete file)

Attached patch patch v.1 (obsolete) — Splinter Review
flash was disabled.  when all of the flash fixups land, we need to renable flash in fennec.
Attachment #408325 - Flags: review?(mark.finkle)
Depends on: 472821, 521255, 492848, 521257, 524339
Attachment #408325 - Flags: review?(mark.finkle) → review-
Comment on attachment 408325 [details] [diff] [review]
patch v.1

>diff -r 7972f6374613 app/mobile.js

> pref("toolkit.defaultChromeURI", "chrome://browser/content/browser.xul");
>+pref("browser.chromeURL", "chrome://browser/content/");
>+
>+#if MOZ_PLATFORM_HILDON
> pref("general.useragent.extra.mobile", "@APP_UA_NAME@/@APP_VERSION@");
>-pref("browser.chromeURL", "chrome://browser/content/");
>+#else
>+pref("general.useragent.extra.mobile", "@APP_UA_NAME@/@APP_VERSION@ Maemo");
>+#endif

Don't do this part. The platform UA change is enough.
yeah, ignore app/mobile.js.  sorry about that.  is the browser.js change good?
(In reply to comment #2)
> yeah, ignore app/mobile.js.  sorry about that.  is the browser.js change good?

browser.js looks good, but could you add a comment to remove the temporary pref someday?
Attached patch patch v.2Splinter Review
Assignee: nobody → doug.turner
Attachment #408325 - Attachment is obsolete: true
Attachment #408339 - Flags: review?(mark.finkle)
Attachment #408339 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/bd4baeedf477
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
verified FIXED (no crashes and flash is enabled on hulu, youtube and yahoo finance) on the n900:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b2pre) Gecko/20091027 Namoroka/3.6b2pre Fennec/1.0b5pre


...but there's low memory conditions popping up all over the n810 with flash enabled on the aforementioned sites. We need to relnote this for b5.
Status: RESOLVED → VERIFIED
Keywords: relnote
You need to log in before you can comment on or make changes to this bug.