524413 - re-enable the flash plugin

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Doug Turner (:dougt)]

Attachment: patch v.1

flash was disabled.  when all of the flash fixups land, we need to renable flash in fennec.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 408325 [details] [diff] [review]
patch v.1

>diff -r 7972f6374613 app/mobile.js

> pref("toolkit.defaultChromeURI", "chrome://browser/content/browser.xul");
>+pref("browser.chromeURL", "chrome://browser/content/");
>+
>+#if MOZ_PLATFORM_HILDON
> pref("general.useragent.extra.mobile", "@APP_UA_NAME@/@APP_VERSION@");
>-pref("browser.chromeURL", "chrome://browser/content/");
>+#else
>+pref("general.useragent.extra.mobile", "@APP_UA_NAME@/@APP_VERSION@ Maemo");
>+#endif

Don't do this part. The platform UA change is enough.

Comment 2

[Doug Turner (:dougt)]

yeah, ignore app/mobile.js.  sorry about that.  is the browser.js change good?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #2)
> yeah, ignore app/mobile.js.  sorry about that.  is the browser.js change good?

browser.js looks good, but could you add a comment to remove the temporary pref someday?

Comment 4

[Doug Turner (:dougt)]

Attachment: patch v.2

Comment 5

[Doug Turner (:dougt)]

http://hg.mozilla.org/mobile-browser/rev/bd4baeedf477

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED (no crashes and flash is enabled on hulu, youtube and yahoo finance) on the n900:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b2pre) Gecko/20091027 Namoroka/3.6b2pre Fennec/1.0b5pre


...but there's low memory conditions popping up all over the n810 with flash enabled on the aforementioned sites. We need to relnote this for b5.