Closed Bug 524422 Opened 15 years ago Closed 15 years ago

Disable PGO for sqlite3 with Sun Studio on Solaris

Categories

(Firefox Build System :: General, defect)

All
OpenSolaris
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

Details

Attachments

(1 file)

Sun Studio xprofile=collect will insert some undefined symbols into shared object.
These symbols are linked into executables, like firefox-bin.
We cannot link these shared object with -z defs flag, which disallows unresolved symbols.

NSS uses mozilla internal sqlite3, and it is compiled with -z defs flag.
So we have to disable PGO for sqlite3.
Attached patch patchSplinter Review
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #408338 - Flags: review?(ted.mielczarek)
Comment on attachment 408338 [details] [diff] [review]
patch

I'd leave out the bug reference. I only like having bug numbers when they point to open bugs that we intend to fix. As a historical note, people can just check the blame.
Attachment #408338 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/bf9dbda3a129
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: