Closed
Bug 524470
Opened 15 years ago
Closed 15 years ago
CEIP: Rename "interactive" to "source" and log isInteractive=true as source=inputbox
Categories
(Other Applications :: ChatZilla, defect)
Other Applications
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bugzilla-mozilla-20000923, Assigned: bugzilla-mozilla-20000923)
Details
(Whiteboard: [cz-0.9.86])
Attachments
(1 file)
|
897 bytes,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
Currently the CEIP code logs e.source and e.isInteractive in the "interactive" attribute as the values "keyboard", "menu", "mouse" and "true". The last one being commands with no e.source but e.isInteractive=true (commands typed by the user). I'd like to change this so typed commands log the value "inputbox" (this conversion is currently done by my CEIP log processor) and rename the attribute to "source" for clarity about what it is logging (as a bonus, this will save some space in the log file).
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: rginda → silver
Status: NEW → ASSIGNED
Attachment #415498 -
Flags: review?(gijskruitbosch+bugs)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 415498 [details] [diff] [review] Rename attribute and true=>inputbox r=me Note that your log processor will need to deal with files that have both formats...
Attachment #415498 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Pushed --> FIXED.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.86]
You need to log in
before you can comment on or make changes to this bug.
Description
•