Add --setpref argument to runreftest.py

RESOLVED FIXED

Status

Testing
Reftest
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: jgriffin, Assigned: jgriffin)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
Created attachment 408410 [details] [diff] [review]
patch

bc said it would be handy to have the mochitest --setpref argument (see bug 519574) available in reftest.  Attached is a patch which does that.
Attachment #408410 - Flags: review?(ted.mielczarek)
Maybe we should give automation.py a mechanism for common options (i.e., pass it the option parser before calling parse_args, and then pass it the resulting options object where needed) so we don't have to duplicate this type of code?
(Assignee)

Comment 2

9 years ago
We have such a method in automationutils.py, addCommonOptions:

http://mxr.mozilla.org/mozilla-central/source/build/automationutils.py#71

Wasn't sure we wanted in this in runxpcshelltests.py too.  If so, I can move it there.
(Assignee)

Comment 3

9 years ago
runxpcshelltests.py doesn't currently build a user.js file.  If I add such a file will it be used by xpcshell?  If not, it makes sense to keep --setpref out of addCommonOptions(), I think.
It doesn't make sense for xpcshell tests, not all tests use a profile. Feel free to invent a new common options sort of thing in automation.py. automationutils.py is shared among runtests.py, runreftest.py, runxpcshelltests.py, but automation.py is not used by runxpcshelltests.py.
(Assignee)

Comment 5

9 years ago
Created attachment 409002 [details] [diff] [review]
patch v2

This patch puts the --setpref option in automation.py, used by both runtests.py and runreftest.py.
Attachment #408410 - Attachment is obsolete: true
Attachment #409002 - Flags: review?(ted.mielczarek)
Attachment #408410 - Flags: review?(ted.mielczarek)
Assignee: nobody → jgriffin
Attachment #409002 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 6

9 years ago
Pushed as http://hg.mozilla.org/mozilla-central/rev/171e825463a5
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.