js/src/trace-test/tests/sunspider/check-date-format-xparb.js is broken everywhere but the US

RESOLVED FIXED

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

Other Branch
Points:
---
Bug Flags:
wanted1.9.2 +
in-testsuite +

Firefox Tracking Flags

(status1.9.2 beta5-fixed)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
The results depend on when your locale enters and leaves Daylight Savings Time.
(Assignee)

Comment 1

9 years ago
Created attachment 408417 [details] [diff] [review]
v1

The answer is not to check so much.

This loses a bunch of phony coverage in favor of a small amount of real coverage. I'd rather not spend time improving it further.
Assignee: general → jorendorff
Status: NEW → ASSIGNED
Attachment #408417 - Flags: review?(igor)
(Assignee)

Comment 2

9 years ago
Closely related to bug 515254.
As a non-US-west-coaster, I say "hear hear" to this patch.  But a comment in the code briefly explaining why we're not doing exact matching would be nice.
(Assignee)

Comment 4

9 years ago
Comment on attachment 408417 [details] [diff] [review]
v1

I'll add this comment.

// No exact match because the output depends on the locale's time zone. See bug 524490.
Attachment #408417 - Flags: review?(igor) → review?(gal)

Updated

9 years ago
Attachment #408417 - Flags: review?(gal) → review+

Comment 5

9 years ago
Comment on attachment 408417 [details] [diff] [review]
v1

SunSpider. A constant source of embarrassment.
(Assignee)

Comment 6

9 years ago
http://hg.mozilla.org/tracemonkey/rev/4b5938c3b527
Flags: wanted1.9.2?
Whiteboard: fixed-in-tracemonkey

Updated

9 years ago
Flags: in-testsuite+

Comment 7

9 years ago
http://hg.mozilla.org/mozilla-central/rev/4b5938c3b527
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Flags: wanted1.9.2? → wanted1.9.2+
These bugs landed after b4 was cut. Moving flag out.
status1.9.2: beta4-fixed → final-fixed
You need to log in before you can comment on or make changes to this bug.