Closed Bug 524526 Opened 11 years ago Closed 11 years ago

Zooming sometimes zooms to incorrect positions

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
fennec1.0b5

People

(Reporter: stechz, Assigned: stechz)

References

()

Details

Attachments

(1 file, 1 obsolete file)

After doubletapping around for a while, zooming occasionally gets into a funk where double tapping on anything goes to the wrong place.  Restarting Fennec reverts to normal behavior.  Discovered on an article at cnn.com.
Only begins happening after a link opens something in a new window.  I assume this is because the content scrollarea has changed to something besides 0,0.
Attached patch Force viewport resize (obsolete) — Splinter Review
When loading, beginBatchOperation has been called, so scrollTo will not scroll to the correct place unless the container size has been resized.  In order to have zoom look correct by the time the zoom operation is over, this forces a viewport refresh.
Assignee: nobody → webapps
Attachment #408676 - Flags: review?(mark.finkle)
Zooming still wasn't working because zoomToFit was being called every couple of seconds.  I fixed the zoomChanged flag and zooming during load is looking much better.

I think I've seen these changes in one of your patches that never landed Mark, whatever happened to it?
Attachment #408676 - Attachment is obsolete: true
Attachment #409147 - Flags: review?(mark.finkle)
Attachment #408676 - Flags: review?(mark.finkle)
Comment on attachment 409147 [details] [diff] [review]
Fix zoomChanged flag

I'm starting to worry about the overall affect on performance our "correctness" patches are causing.

I'd rather be "correct" first and "fast" second. We need to start profiling again.
Attachment #409147 - Flags: review?(mark.finkle) → review+
pushed:
https://hg.mozilla.org/mobile-browser/rev/05b28384470b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → B5
verified FIXED on build (opened a couple of tabs, waited for each to load and then performed a couple of zooms on the original tab):

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b2pre) Gecko/20091102 Namoroka/3.6b2pre Fennec/1.0b5
Status: RESOLVED → VERIFIED
Component: General → Panning/Zooming
You need to log in before you can comment on or make changes to this bug.