524526 - Zooming sometimes zooms to incorrect positions

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Benjamin Stover (:stechz)]

After doubletapping around for a while, zooming occasionally gets into a funk where double tapping on anything goes to the wrong place.  Restarting Fennec reverts to normal behavior.  Discovered on an article at cnn.com.

Comment 1

[Benjamin Stover (:stechz)]

Only begins happening after a link opens something in a new window.  I assume this is because the content scrollarea has changed to something besides 0,0.

Comment 2

[Benjamin Stover (:stechz)]

Attachment: Force viewport resize

When loading, beginBatchOperation has been called, so scrollTo will not scroll to the correct place unless the container size has been resized.  In order to have zoom look correct by the time the zoom operation is over, this forces a viewport refresh.

Comment 3

[Benjamin Stover (:stechz)]

Attachment: Fix zoomChanged flag

Zooming still wasn't working because zoomToFit was being called every couple of seconds.  I fixed the zoomChanged flag and zooming during load is looking much better.

I think I've seen these changes in one of your patches that never landed Mark, whatever happened to it?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 409147 [details] [diff] [review]
Fix zoomChanged flag

I'm starting to worry about the overall affect on performance our "correctness" patches are causing.

I'd rather be "correct" first and "fast" second. We need to start profiling again.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/05b28384470b

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED on build (opened a couple of tabs, waited for each to load and then performed a couple of zooms on the original tab):

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b2pre) Gecko/20091102 Namoroka/3.6b2pre Fennec/1.0b5