Amalgamating remaining preferences (defaults + xulrunner app ones)

NEW
Unassigned

Status

()

Core
Preferences: Backend
9 years ago
9 years ago

People

(Reporter: (dormant account), Unassigned)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

9 years ago
I need guidance on how to combine the remaining piles of preferences.

I think it's fairly straightforward to change gre_dir/defaults/pref/*.js to gre_dir/default-prefs.js.

How do these preferences differ from those shipping xulrunner apps like fennec, which seem to get a bonus pref dir.  

In fennec I see
xulrunner/greprefs.js +
xulrunner/defaults/pref/xulrunner.js <--xulrunner defaults pref
defaults/preferences/mobile[l10n].js <-- fennec prefs

Ideally we'd only read 1 preference file per category. Also ideally all of our preferences would be combined into 1 category resulting in a single pref file.

How close to an ideal situation can we get?

Comment 1

9 years ago
I can't imagine we're actually reading xulrunner/defaults/pref/xulrunner.js at all in that scenario.
(Reporter)

Comment 2

9 years ago
(In reply to comment #1)
> I can't imagine we're actually reading xulrunner/defaults/pref/xulrunner.js at
> all in that scenario.

but we do :( So suggestions on how to fix that are welcome.

pref:/home/taras/builds/fennec/mobile/dist/bin/xulrunner/greprefs.js
/defaults/pref
pref:/home/taras/builds/fennec/mobile/dist/bin/xulrunner/defaults/pref/xulrunner.js
pref:/home/taras/builds/fennec/mobile/dist/bin/defaults/preferences/mobile.js
pref:/home/taras/builds/fennec/mobile/dist/bin/defaults/preferences/mobile-l10n.js
pref:/home/taras/.mozilla/fennec/e13zp5dj.default/prefs.js
(Reporter)

Comment 3

9 years ago
Note these are calls to openPrefFile

Comment 4

9 years ago
You need to figure out why, then.
(Reporter)

Comment 5

9 years ago
(In reply to comment #4)
> You need to figure out why, then.

I know it loads the pref because there is a defaults/ dir that xulrunner/etc prefs are loaded from. Can that pref file can be folded into greprefs.js?

http://mxr.mozilla.org/mozilla-central/source/modules/libpref/src/nsPrefService.cpp#687


And app prefs are loaded from http://mxr.mozilla.org/mozilla-central/source/modules/libpref/src/nsPrefService.cpp#692

This part seems easier. I think here the code should be changed to load NS_APP_PREFS_DEFAULTS_DIR_LIST which would turn into appdir/preferences.js.
You need to log in before you can comment on or make changes to this bug.