524603 - Non-root jobqueue.pl cannot write to data/mailer.testfile

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Max Kanat-Alexander]

data/mailer.testfile is created as being owned by Apache, and writeable only to the owner. This means that if jobqueue.pl is not running as root, it cannot write to data/mailer.testfile (meaning that the Test email delivery method does not work with jobqueue.pl when it is not running as root).

Comment 1

[Max Kanat-Alexander]

And then checksetup.pl tries to change the file's permissions, but if you're not root, it can't because you're not the file's owner.

Comment 2

[Max Kanat-Alexander]

Attachment: v1, for the 3.4 branch

This fixes it. We don't just delete the old mailer.testfile, because it contains data, and there's a vague chance that (since it's a valid mbox) people are using it for something.

Comment 3

[Frédéric Buclin]

Does this also fix bug 348102?

Comment 5

[Max Kanat-Alexander]

(In reply to comment #3)
> Does this also fix bug 348102?

  Ah yeah, it absolutely does.

Comment 6

[Frédéric Buclin]

Comment on attachment 408523 [details] [diff] [review]
v1, for the 3.4 branch

Works fine, but only applies cleanly on the 3.4 branch. It's bitrotten on HEAD.

r=LpSolit for 3.4.

Comment 7

[Frédéric Buclin]

Needs a new patch for 3.6.

Comment 8

[Max Kanat-Alexander]

Attachment: v1 for HEAD

Okay, this one applies on HEAD.

Comment 9

[Frédéric Buclin]

Comment on attachment 417398 [details] [diff] [review]
v1 for HEAD

r=LpSolit

Comment 10

[Max Kanat-Alexander]

tip:

Checking in Bugzilla/Install/Filesystem.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Filesystem.pm,v  <--  Filesystem.pm
new revision: 1.43; previous revision: 1.42
done

3.4:

Checking in Bugzilla/Install/Filesystem.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Filesystem.pm,v  <--  Filesystem.pm
new revision: 1.34.2.1; previous revision: 1.34
done

Comment 11

[Max Kanat-Alexander]

Attachment: Fix Tinderbox Warning

Tinderbox is currently saying: No such file or directory at Bugzilla/Install/Filesystem.pm line 465.

But it only says it once, in the checksetup tinderbox, so I'd assume that the problem happens when the testfile was never created in the first place.

Comment 12

[Frédéric Buclin]

Comment on attachment 417576 [details] [diff] [review]
Fix Tinderbox Warning

Yes, looks good to me. r=LpSolit

Comment 13

[Max Kanat-Alexander]

Checked in the fix:

tip:

Checking in Bugzilla/Install/Filesystem.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Filesystem.pm,v  <--  Filesystem.pm
new revision: 1.44; previous revision: 1.43
done

3.4:

Checking in Bugzilla/Install/Filesystem.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Filesystem.pm,v  <--  Filesystem.pm
new revision: 1.34.2.2; previous revision: 1.34.2.1
done