524659 - Fennec's use of JarMaker.py for processing an objdir jar.mn fails if the objdir is outside of topsrcdir

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

because the l10ndirs logic asserts that srcdir.startswith(topsrc) so that the l10ndir logic works correctly. In the fennec case, srcdir is the objdir where where the dynamically generated jar.mn lives. Since we pass in src directories manually we don't need that logic, so I proposed just making it conditional rather than an assert.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Not sure whether the comment's right, suggestions welcome!

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: 192 version

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 408578 [details] [diff] [review]
patch

Please add another section to the makeJars docstring, something like

This logic is disabled if the jar.mn path is not inside the topsrcdir.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/57e42052ea96

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 408578 [details] [diff] [review]
patch

Requesting approval for 1.9.2. I'd like to land those together with the two patches in bug 505713 to not fork that code, and because they're good to take.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

This is a pita for Fennec developers, many of whom use objdirs outside of the srcdir

Comment 8

[Axel Hecht [:Pike]]

http://hg.mozilla.org/releases/mozilla-1.9.2/pushloghtml?changeset=c399c316ae22, landed on 1.9.2