524667 - "Close other tabs" only closes alternate tabs

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[P. Morton]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.1.5pre) Gecko/20091025 Ubuntu/9.10 (karmic) Shiretoko/3.5.5pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5pre) Gecko/20091026 Shredder/3.0pre

Right click on a tab and select "Close other tabs". Not all tabs close.


Reproducible: Always

Steps to Reproduce:
1.Setting up 4 tabs labelled 1,2,3 and 4
2.Right click on tab 1 and select "close other tabs". Tabs 1 AND 3 remain.
3.Right click on tab 2 and select "close other tabs". Tabs 2 AND 4 remain.
4.Right click on tab 3 and select "close other tabs". Tabs 3 AND 2 remain.
5.Right click on tab 4 and select "close other tabs". Tabs 4 AND 2 remain.
Actual Results:  
As above

Expected Results:  
All other tabs would close, except the one originally clicked

Comment 1

[Bobby Johnson [:rjohnson19]]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.5pre) Gecko/20091027 Shredder/3.0pre

I see basically the same problem in safe mode. Sometimes only one tab out of four closes.

Comment 2

[Onno Ekker [:nONoNonO UTC+1]]

I have set mail.tabs.closeWindowWithLastTab to false. For me first tab never closes and other tabs close a bit different from settings above, but there are definitely more tabs open than expected after closing other tabs...

Comment 3

[Rain [:rain1] (inactive)]

Attachment: patch

Comment 4

[Rain [:rain1] (inactive)]

It's alternate because we skip a tab each time we close a tab.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 411163 [details] [diff] [review]
patch

>+            for (var i = this.tabInfo.length - 1; i >= 0; i--) {

nit: let.

r+a=Standard8

Would be nice to get unit tests at some stage on this, so please set in-testsuite? if you don't have them already.

Comment 6

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/comm-central/rev/81be9737934c
http://hg.mozilla.org/releases/comm-1.9.1/rev/09a2ff867204