Incorrect build ID in Warpzilla titlebar

CLOSED FIXED in M18

Status

SeaMonkey
Build Config
P3
normal
CLOSED FIXED
18 years ago
13 years ago

People

(Reporter: Barry Marshall, Assigned: cls)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
Tested with Warpzilla nightly build 0912 on WSeB base with Scitech DD 
on TP770X.

1) Start Warpzilla
2) Help - About Mozilla

The build ID in the Title Bar and on this page don't match.
(Reporter)

Comment 1

18 years ago
Created attachment 14596 [details]
Note the two different build ID's

Comment 2

18 years ago
Two fold problem here:

1. MOZILLA_OFFICIAL should be set on our nightly build machine.

2. The aboutime.pl script in mozilla/config is not working correctly on OS/2.

I sent a note to our build person about 1

2 is being hashed out on IRC - probably to be fixed by jag
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 3

18 years ago
Our main problem here is that aboutime.pl in config assumes that the platform 
rename will succeed if the destination exists.

This is bad.

aboutime.pl should delete the destination file before attempting the rename.
Assignee: mkaply → cls
Component: Browser-General → Build Config
QA Contact: doronr → granrose
(Reporter)

Comment 4

18 years ago
Is M18 reasonable for this?
(Assignee)

Comment 5

18 years ago
mkaply, see if this fixes it for you.

Index: config/aboutime.pl
===================================================================
RCS file: /cvsroot/mozilla/config/aboutime.pl,v
retrieving revision 3.4
diff -u -r3.4 aboutime.pl
--- aboutime.pl 1999/08/24 00:56:04     3.4
+++ aboutime.pl 2000/09/19 18:31:08
@@ -26,4 +26,5 @@
 close INFILE;
 close OUTFILE;
 
+unlink $ARGV[0];
 rename "$ARGV[0].old", "$ARGV[0]";
Status: NEW → ASSIGNED
Target Milestone: --- → M18

Comment 6

18 years ago
That diff fixes my problem.

Comment 7

18 years ago
r=mkaply
(Assignee)

Updated

18 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

18 years ago
Fix has been checked in.

Comment 9

17 years ago
verified.
Status: RESOLVED → VERIFIED
(Reporter)

Comment 10

17 years ago
Yup, I'm happy.  Let's close 'er up.
Status: VERIFIED → CLOSED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.