524763 - Regexp/string confusion in generateTextForTextNode in about:support

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jesse Ruderman]

let text = node.textContent.trim().replace("\n[ \t]*", "\n" + indent);

Shouldn't that be a regexp rather than a literal string?

Comment 1

[Curtis Bartley [:cbartley]]

Attachment: string -> regex literal, v1

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 409455 [details] [diff] [review]
string -> regex literal, v1

>+  let text = node.textContent.trim().replace(/\n/g, "\n" + indent);

You don't need a regexp for this:
.replace("\n", "\n" + indent, "g");

Comment 3

[Dão Gottwald [:dao]]

(In reply to comment #2)
> (From update of attachment 409455 [details] [diff] [review])
> >+  let text = node.textContent.trim().replace(/\n/g, "\n" + indent);
> 
> You don't need a regexp for this:
> .replace("\n", "\n" + indent, "g");

made it so:

http://hg.mozilla.org/mozilla-central/rev/6658101fa6c7

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/ca2df1029f7f