524778 - XRE_GetProcessType returns 0 (default) for child processes during leak log initialization

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Jonathan Griffin (:jgriffin)]

I'm trying to get leak logging to handle child processes better, and was planning on using XRE_GetProcessType() inside the log file init function to determine whether it was being called by the default process or by a child process.

However, this function always returns 0 (default), when called from InitLog() in nsTraceRefcntImpl.cpp.  This happens because sChildProcessType is not set inside XRE_InitChildProcess() until later in the function, so InitLog() gets called while sChildProcessType is still GeckProcessType_Default.  Moving the line:

    sChildProcessType = aProcess;

to the top of XRE_InitChildProcess() fixes this problem, but I am uncertain if it might cause others.

Comment 1

[Benjamin Smedberg]

That sounds fine to me.

Comment 2

[Jonathan Griffin (:jgriffin)]

This is fixed by bug 519570.