524793 - Solved topics show up when "Unsolved" filter is chosen

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

1. Load the Firefox forum: https://support-stage.mozilla.org/en-US/forum/1
2. Click on "Show: Unsolved Topics" (https://support-stage.mozilla.org/en-US/forum/1?thread_sort_mode=lastPost_desc&issue_solved=unsolved)
3. Look at the "Type" column's icon

Expected Results:

There should be no "Solved" threads present

Actual Results:

There are a few "Solved" threads, indicated by the green checkmark and their status

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: wtf?

Comment 2

[Paul Craciunoiu [:paulc]]

Hmm... I wonder if I regressed this with the sorting headers bug :)

Comment 3

[Paul Craciunoiu [:paulc]]

This happens when solving a thread by editing and setting status to "solved", which implies that there is no "solved" child for that thread. As soon as there is a "solved" child, however, the thread is no longer listed.

I'm not sure how to fix it without seriously impacting performance. Maybe we can live with it?

Comment 4

[Paul Craciunoiu [:paulc]]

Oops. Nevermind. I think it actually shows if the *last child* isn't solved.

James, the filtering happens at commentslib.php:844
Maybe you can take a look, see if you have some ideas?

Comment 5

[Paul Craciunoiu [:paulc]]

Attachment: v1

I figured it out. This fix should be acceptable and should cover the following case:
A thread is marked as solved, but none if its children are.

Solution: filter out solved threads *again*, by the parent post.

Hope there aren't any other exceptions now.

Comment 6

[James Socol [:jsocol, :james]]

Comment on attachment 412366 [details] [diff] [review]
v1

WFM.

Comment 7

[Paul Craciunoiu [:paulc]]

r56280

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://support-stage.mozilla.org/en-US/forum/1?thread_sort_mode=lastPost_desc&issue_solved=unsolved; nice!