524811 - add glowing Firefox icon in the taskbar when downloads are completed

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[juan becerra [:juanb]]

In IE8 when a download is completed, and the app is minimized, its icon in the taskbar starts to glow. In 3.6b1(build2) and trunk that's not the case. This is likely related to on-going work in bug 474060.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Watching IE behavior it looks like they use both the "app requesting focus" nag (yellow/orange blink), and keep the download progress displayed at 100% until the download is dismissed.

I'm looking into finishing bug 474060 and as soon as it gets done I'll post some screenshots here to get some UX love and see what behavior we want to implement.

Comment 2

[u88484]

I'm pretty sure this worked once bug 474060 landed but now I can't seem to get the glow effect when firefox is minimized and a download complete.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

The glow effect is the effect of a window asking for attention.  The Download Manager does ask for attention when a download starts and it's already opened but not focused, so perhaps the observation was of a quick download starting and completing.

Comment 4

[u88484]

Ok, I thought it was a yellow glow after the download had complete.  Sorry for any confusion.

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Attachment: Taskbar - Download Progress - states

This image is a quick summary of the behavior and visual states for download progress that we have at the moment.

The orange blink is the Windows' styling for "a window requesting attention". Currently, we blink the download manager window, twice, at the beginning of a download, only if the download manager window is already open (if it's not open it's opened and brought to front, instead of requesting attention)

If the download finishes fast enough (before the 2 blinks), the orange glow stays. Otherwise, the glow is overriden whenever the progress display is updated.

So, we do have a bit of an inconsistent behavior (mostly due to the change of styling from windows 7), and nothing to indicate when a download has finished.

Things we can do:

 - Blink when a download finishes
 - Blink when all download finishes
 - Keep download progress at 100% after download finishes (but what about if there are other ongoing downloads)
 - Other combinations of these
 - Keep it as is.

Comment 6

[Alex Limi (:limi) — Firefox UX Team]

My instinct would be (not having used IE8 much):

- Let the progress bar indicate the sum of the downloads
- Let the highlighting (what you refer to as blinking?) indicate whenever any of the downloads are completed.

This way, you know when there's a download that wants your attention, but you can still choose to ignore it if you're waiting for 20 other files to complete.

Comment 7

[:Felipe Gomes (needinfo for replies!)]

Attachment: Get attention on download finished

This patch changes the getAttention calls to the end of a download, rather on the beginning.

On win7, the getAttention call blinks and adds a glow on the taskbar icon (only if the window is not the active one). Also, if there are other downloads going on, the taskbar progress display will override the attention request after a few seconds, so the glow will only remain indefinitely when the last active download finishes.

On other platforms it would just change the call for attention to the end of a download (which makes more sense IMO)

Shawn, what do you think of this change? Do you know what was the reasoning behind calling getAttention when a download begins?
I talked to limi on IRC about making this change and if you like it I'll ask a ui-r? from him too.

Comment 8

[Shawn Wilsher :sdwilsh]

Comment on attachment 442927 [details] [diff] [review]
Get attention on download finished

r=sdwilsh

Comment 9

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 442927 [details] [diff] [review]
Get attention on download finished

Limi, this implements the behavior described in comment #6 that we talked about on IRC some weeks ago.

Comment 10

[Justin Wood (:Callek)]

(In reply to comment #7)
> Created an attachment (id=442927) [details]
> Get attention on download finished

http://hg.mozilla.org/mozilla-central/rev/9be97a5edd72

Comment 11

[[not reading bugmail]]

I can verify the patch worked, but the hourly build after this was fixed, broke it.  see bug 570131.