Closed
Bug 524884
Opened 15 years ago
Closed 15 years ago
Firefox Personal page with locale subdomain looks bad
Categories
(www.mozilla.org :: General, defect)
www.mozilla.org
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: stephend, Assigned: reed)
References
()
Details
(Keywords: regression)
Attachments
(3 files)
700.73 KB,
image/png
|
Details | |
1.77 KB,
patch
|
Details | Diff | Splinter Review | |
2.42 KB,
patch
|
Details | Diff | Splinter Review |
http://en-us.www.mozilla.com/en-US/firefox/3.5.3/whatsnew/ links to http://en-us.www.mozilla.com/en-US/firefox/personal.html in its "Latest and greatest version."
The page looks pretty bad; the attached screenshot should suffice.
http://www.mozilla.com/en-US/firefox/personal.html, without the locale domain-prefix, looks fine.
Reporter | ||
Comment 1•15 years ago
|
||
Comment 2•15 years ago
|
||
Whoa, this is pretty messed up. Obviously we need to fix asap, but in the short term is there any reason we can't change the links from the whatsnew page so they don't have the locale prefix?
Comment 3•15 years ago
|
||
I have no idea how this happened. Ryan might though.
Assignee | ||
Comment 4•15 years ago
|
||
Here's the patch to fix the problem. I tried to commit it, but I got access denied. Apparently, you all don't love me anymore.
Assignee: nobody → reed
Status: NEW → ASSIGNED
Comment 5•15 years ago
|
||
Landed on production.
Comment 6•15 years ago
|
||
Landed on stage as well. Talking to IT to get this live sooner rather than later.
Updated•15 years ago
|
Assignee: reed → server-ops
Component: www.mozilla.com → Server Operations: Web Content Push
Product: Websites → mozilla.org
QA Contact: www-mozilla-com → mrz
Version: unspecified → other
Comment 8•15 years ago
|
||
Push doesn't seem to have fixed the issue.
Comment 9•15 years ago
|
||
Mike is investigating. He'll change the assignee when he has something to push.
Assignee: shyam → morgamic
Comment 10•15 years ago
|
||
I must have copied over an out of date .htaccess file when doing the manual merge.
Comment 11•15 years ago
|
||
Ok, so it looks like we're essentially backing out r53668, but there's a bunch of other stuff in the attachment.
Comment 12•15 years ago
|
||
Just whitespace, nm - pushing to trunk and stage first.
Comment 13•15 years ago
|
||
morgamic: I already backed all that out (landed the patch) on production and stage (but not trunk per the bug).
Comment 14•15 years ago
|
||
Checked r54437 onto trunk. Checked the content type for css and js passed through .php, seemed ok. Adding the file extension makes the locale redirects detect this as something it shouldn't inject the locale into. Mostly this rule:
ewriteCond %{SCRIPT_FILENAME} !^.*(php|css|js|jpg|gif|png|ico|pdf|swf)
Reporter | ||
Comment 15•15 years ago
|
||
http://en-us.www-trunk.stage.mozilla.com/en-US/firefox/personal.html 302s into https://www-trunk.stage.mozilla.com/en-US/firefox/personal.html, which looks fine to me.
Comment 16•15 years ago
|
||
I pushed to stage and prod.
Assignee | ||
Comment 17•15 years ago
|
||
Improve morgamic's change.
Reporter | ||
Comment 18•15 years ago
|
||
Updated•15 years ago
|
Assignee: morgamic → reed
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•15 years ago
|
Component: Server Operations: Web Content Push → www.mozilla.com
Product: mozilla.org → Websites
QA Contact: mrz → www-mozilla-com
Reporter | ||
Comment 19•15 years ago
|
||
Verified FIXED; thanks to all for the quick turnaround.
Status: RESOLVED → VERIFIED
Updated•13 years ago
|
Component: www.mozilla.org/firefox → www.mozilla.org
Updated•12 years ago
|
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in
before you can comment on or make changes to this bug.
Description
•