524891 - Leading whitespace is trimmed from all comments

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Max Kanat-Alexander]

I don't know if this is a recent regression or not, but leading whitespace is being trimmed from comments. I suspect format_comment.txt.tmpl as the culprit, because leading whitespace is automatically trimmed from templates.

Comment 1

[Max Kanat-Alexander]

The patch on bug 472217 fixes this for HEAD.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

And here's a patch against HEAD that I assume will apply equally well to the branches.

Comment 3

[Frédéric Buclin]

This is not a regression. This is a very old bug, see bug 56039 (dupe). So this is not a blocker. :)

Comment 4

[Frédéric Buclin]

Comment on attachment 408787 [details] [diff] [review]
v1

Wow, this is a big hack. I really don't like it. Could you give a look at bug 56039 comment 6 and 7? I even think we should mark this bug as a dupe of bug 56039 and upload a less hacky-patch there.

Comment 5

[Max Kanat-Alexander]

No, it is indeed a regression. Try it on the bugzilla-3.2-branch installation on landfill. bug 56039 is only about the description field, and was probably fixed in 3.0 when we moved to Bug->create.

Comment 6

[Max Kanat-Alexander]

(In reply to comment #4)
> (From update of attachment 408787 [details] [diff] [review])
> Wow, this is a big hack. I really don't like it. Could you give a look at bug
> 56039 comment 6 and 7? I even think we should mark this bug as a dupe of bug
> 56039 and upload a less hacky-patch there.

  bug 56039 comment 7 is what this patch does.

Comment 7

[Max Kanat-Alexander]

Comment on attachment 408787 [details] [diff] [review]
v1

LpSolit: This is a blocker. There is not another solution to the problem. Can I get a review on it?

Comment 8

[Max Kanat-Alexander]

This is still a blocker because it affects the XML format of a bug as well.

Comment 9

[Frédéric Buclin]

Comment on attachment 408787 [details] [diff] [review]
v1

>Index: template/en/default/bug/format_comment.txt.tmpl

> [%- ELSE -%]
>-[%- comment.body %]
>+X[%- comment.body %]

Nit: I don't think these - are necessary. They could probably go away (maybe on tip only in case we regress something; you would have to test first).

r=LpSolit

Comment 10

[Max Kanat-Alexander]

(In reply to comment #9)
> Nit: I don't think these - are necessary. They could probably go away (maybe on
> tip only in case we regress something; you would have to test first).

  Oh, you're probably right. Yeah, I don't want to risk it on the branch though.

Comment 11

[Max Kanat-Alexander]

I removed the -'s on HEAD.

tip:

Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.294; previous revision: 1.293
done
Checking in template/en/default/bug/format_comment.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/format_comment.txt.tmpl,v  <--  format_comment.txt.tmpl
new revision: 1.4; previous revision: 1.3
 done
Checking in template/en/default/email/newchangedmail.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/email/newchangedmail.txt.tmpl,v  <--  newchangedmail.txt.tmpl
new revision: 1.16; previous revision: 1.15
done

3.4:

Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.276.2.12; previous revision: 1.276.2.11
done
Checking in template/en/default/bug/format_comment.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/format_comment.txt.tmpl,v  <--  format_comment.txt.tmpl
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
Checking in template/en/default/email/newchangedmail.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/email/newchangedmail.txt.tmpl,v  <--  newchangedmail.txt.tmpl
new revision: 1.12.2.4; previous revision: 1.12.2.3
done