524900 - treat mobile doctypes like we treat handheld friendly content

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

generally content that specifies a mobile doctype is designed to be fit to screen width, just as content with the handheld friendly meta tag

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch v.2

this patch actually sets the width correctly, the previous one only set the zoom

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 408803 [details] [diff] [review]
patch v.2

>     var handheldFriendly = windowUtils.getDocumentMetadata("HandheldFriendly");

Change to "let" while you're here

>     
>-    if (handheldFriendly == "true") {
>+    
>+    if (handheldFriendly == "true" ||
>+        (browser.contentDocument.doctype && 
>+         (browser.contentDocument.doctype.publicId.search("WAP") != -1||
>+	  browser.contentDocument.doctype.publicId.search("WML") != -1||
>+	  browser.contentDocument.doctype.publicId.search("Mobile")!= -1))) {

Can you make a local var for this logic?

var handheldDoctype = (browser.contentDocument.doctype && 
        (browser.contentDocument.doctype.publicId.search("WAP") != -1 ||
        browser.contentDocument.doctype.publicId.search("WML") != -1 ||
        browser.contentDocument.doctype.publicId.search("Mobile")!= -1));

then use it in the if test

Also, you have TABs in there

>     let handheldFriendly = windowUtils.getDocumentMetadata("HandheldFriendly");
>-    if (handheldFriendly == "true") {
>+    if (handheldFriendly == "true" ||
>+        (browser.contentDocument.doctype && 
>+         (browser.contentDocument.doctype.publicId.search("WAP") != -1||
>+	  browser.contentDocument.doctype.publicId.search("WML") != -1||
>+	  browser.contentDocument.doctype.publicId.search("Mobile")!= -1))) {

Same here (including the TABs)

r+ with nits fixed

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch with nits fixed

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mobile-browser/rev/cab142d04282

Comment 5

[Aakash Desai [:aakashd]]

Brad, I don't have any real experience with WML and WAP docs. Is this patch affecting maemo builds and winmo builds or only winmo builds?

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

It effects both, you'll notice the text on m.* sites is more readable and laid out better.  For example m.espn.go.com is roughly twice as big as it was prior to landing on the Touch Pro.