Closed Bug 524984 Opened 15 years ago Closed 15 years ago

Electrolysis should build and run on gcc 4.2


(Firefox Build System :: General, defect)

Not set


(Not tracked)



(Reporter: cjones, Unassigned)




(1 obsolete file)

Probably want to test with FC8 and maybe Ubuntu 8.04, at least.
Run, yes. Build, I don't care quite so much. Do we know what's not building correctly? Is it something we can configure test to at least error out early instead of producing weird results halfway through a build, or even just not working quite right?
Component: IPC → Build Config
QA Contact: ipc → build-config
I think Mozilla developers are going to be annoyed if the e10s merge requires them to upgrade their linux distros.
Let's figure out exactly what the problem is. Smaug was using -ggdb -feliminate-unused-debug-symbols and most of his problems went away when he stopped using those, right? It's not clear to me that we actually have a problem yet, or what its scope is.
This doesn't block landing in m-c, though it may block enabling the pref by default.
Blocks: OOPP
No longer blocks: 523094
(In reply to comment #4)
> This doesn't block landing in m-c, though it may block enabling the pref by
> default.

Since I don't think we want to land on m-c with maemo-fenntrolysis disabled, I think this should block.
No longer blocks: 523094
The particular issue in bug 525677 sure does, since it turns the tinderbox red! But I still don't think this bug is well-specified enough to block anything.
According to [1], our scratchbox uses gcc 4.2.1.  If that's true, then fixing bug 525677 isn't going to turn the tree green, because we should fail to link any binaries.  I can confirm that that's true for Ubuntu 8.04 / gcc 4.2.4 on x86.

Summary: Electrolysis should build and run on older linux distros / gccs → Electrolysis should build and run on gcc 4.2
It built fine until .asyncDrawXULElement landed. I don't think anyone has actually tested those binaries to see if they run.
Attached patch build fixes (obsolete) — Splinter Review
|explicit| copy ctors have different semantics in gcc 4.2, go to the lowest common denominator
Comment on attachment 410083 [details] [diff] [review]
build fixes

Thought I had these in different patches.  Anyways, the other fix was avoiding the typeinfo visibility bug, by ahem, hackefarious purposes.  I'm not really sure what the best "real" fix is ... test?
Attachment #410083 - Attachment description: IPDL fix → build fixes
We should be golden on 4.2 now, closing.
Closed: 15 years ago
Resolution: --- → FIXED
Attachment #410083 - Attachment is obsolete: true
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.