52501 - Crash when administering my domain! :) (fix attached)

Status: VERIFIED INVALID

(Core :: Networking, defect, P3)

Description

[Anthony Brown]

I haven't had time to reduce the test case, but I get a consistent crash
dereferencing a null mChannel in nsHTTPServerListener::OnDataAvailable when
viewing this page.  It is opening up a link in a new window:

 <li><a href="mydomain/domain-info?domainid=53939"
target="_new">pollmann.com</a> 

Here's a simple bullet-proofing fix:

Index: nsHTTPResponseListener.cpp
===================================================================
RCS file:
/cvsroot/mozilla/netwerk/protocol/http/src/nsHTTPResponseListener.cpp,v
retrieving revision 1.129
diff -u -r1.129 nsHTTPResponseListener.cpp
--- nsHTTPResponseListener.cpp	2000/09/05 21:22:33	1.129
+++ nsHTTPResponseListener.cpp	2000/09/13 18:53:10
@@ -464,6 +464,7 @@
 
     if (NS_SUCCEEDED(rv) && i_Length) {
         PRBool bApplyConversion = PR_TRUE;
+        if (!mChannel) return NS_ERROR_FAILURE;
         (void) (mChannel->GetApplyConversion(&bApplyConversion));
 
         if (bApplyConversion && !mCompressHeaderChecked)

Comment 1

[Eric Pollmann]

oops, duplicate ;)

Comment 2

[John Unruh]

Verified dupe.