Closed Bug 525088 Opened 15 years ago Closed 15 years ago

clean up getZoomForPage

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Product:
Firefox for Android Graveyard
Component:
Panning/Zooming
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
fennec1.0b5

People

(Reporter: Gavin, Assigned: Gavin)

Details

Attachments

(1 file, 2 obsolete files)

better patch
4.03 KB, patch
blassey
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch patch (obsolete) — — Splinter Review 
get rid of unnecessary xpcom crossing, else-after-return
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #408943 - Flags: review?(mark.finkle)
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #408943 -
        Attachment is obsolete: true

        Attachment #408946 -
        Flags: review?(mark.finkle)

        Attachment #408943 -
        Flags: review?(mark.finkle)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        better patch
        — 
          — Splinter Review
      

    


  
adds a Util.contentIsHandheld to share code

        Attachment #408949 -
        Flags: review?(bugmail)

        Attachment #408946 -
        Attachment is obsolete: true

        Attachment #408946 -
        Flags: review?(mark.finkle)

        Attachment #408949 -
        Flags: review?(bugmail) → review+

    
    

    
  
https://hg.mozilla.org/mobile-browser/rev/5d2d8a352d68
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Future
Target Milestone: Future → B5

    
    

    
  
how can I verify this?

    
    

    
  
code verification in MXR

    
    

    
  
That's because I landed a patch on top of it, which changed the original code a bit. But you can see the contentIsHandheld method still being used:
http://mxr.mozilla.org/mobile-browser/source/chrome/content/BrowserView.js#578
Status: RESOLVED → VERIFIED
Component: General → Panning/Zooming

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: