If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

clean up getZoomForPage

VERIFIED FIXED in fennec1.0b5

Status

Fennec Graveyard
Panning/Zooming
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

Trunk
fennec1.0b5

Details

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
Created attachment 408943 [details] [diff] [review]
patch

get rid of unnecessary xpcom crossing, else-after-return
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #408943 - Flags: review?(mark.finkle)
Created attachment 408946 [details] [diff] [review]
patch
Attachment #408943 - Attachment is obsolete: true
Attachment #408946 - Flags: review?(mark.finkle)
Attachment #408943 - Flags: review?(mark.finkle)
Created attachment 408949 [details] [diff] [review]
better patch

adds a Util.contentIsHandheld to share code
Attachment #408949 - Flags: review?(bugmail)
Attachment #408946 - Attachment is obsolete: true
Attachment #408946 - Flags: review?(mark.finkle)
Attachment #408949 - Flags: review?(bugmail) → review+
https://hg.mozilla.org/mobile-browser/rev/5d2d8a352d68
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Future
Target Milestone: Future → B5
how can I verify this?
code verification in MXR
hmm, I am unable to verify this in mxr: 
http://mxr.mozilla.org/mobile-browser/source/chrome/content/BrowserView.js
That's because I landed a patch on top of it, which changed the original code a bit. But you can see the contentIsHandheld method still being used:
http://mxr.mozilla.org/mobile-browser/source/chrome/content/BrowserView.js#578
Status: RESOLVED → VERIFIED
Component: General → Panning/Zooming
You need to log in before you can comment on or make changes to this bug.