525132 - Add-on options section does not get select background color

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

see here:
http://www.flickr.com/photos/madhava_work/4053303923/

the blue is only present during panning of the list, but it's noticeable here.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Removes some hardcoded background colors and adds background color to the settings label only

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 411436 [details] [diff] [review]
patch

>diff --git a/themes/hildon/browser.css b/themes/hildon/browser.css

> setting {
>   color: black;

Is this needed?

> settings .settings-title {

This can just be |.settings-title|, right?

>+  color: #000;

let's use the named colors consistently? (still takes me half a second to remember which of #fff/#000 is black)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed with comments fixed:
https://hg.mozilla.org/mobile-browser/rev/738edf0548fd

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b3pre) Gecko/20091111 Firefox/3.6b2pre Fennec/1.0b5