Closed Bug 525164 Opened 10 years ago Closed 10 years ago

placeitem in BookmarkHelper should not be highlighted on :active

Categories

(Firefox for Android Graveyard :: Bookmarks, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
fennec1.0b5

People

(Reporter: vingtetun, Assigned: vingtetun)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
Steps to reproduce:
 * get the right sidebar
 * bookmark the current page and click edit
 * try to pan the editor

Actual results:
 * The editor have a blue background color

Expected results:
 * no background color
Attachment #409017 - Flags: review?(mark.finkle)
Comment on attachment 409017 [details] [diff] [review]
Patch

Instead, let's be more restrictive on the placeitem:active

placelist > placeitem:active { is blue }
Attachment #409017 - Flags: review?(mark.finkle) → review-
Attached patch PatchSplinter Review
Done as you said.
Attachment #409017 - Attachment is obsolete: true
Attachment #409029 - Flags: review?(mark.finkle)
Attachment #409029 - Flags: review?(mark.finkle) → review+
pushed:
https://hg.mozilla.org/mobile-browser/rev/733635295cb9
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → B5
verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b2pre) Gecko/20091029 Namoroka/3.6b2pre Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091029 Namoroka/3.7a1pre Fennec/1.0b5pre
Status: RESOLVED → VERIFIED
Component: General → Bookmarks
You need to log in before you can comment on or make changes to this bug.