Closed Bug 525184 Opened 10 years ago Closed 10 years ago

Create a virtual places root for Mobile bookmarks

Categories

(Firefox for Android Graveyard :: Bookmarks, defect)

defect
Not set

Tracking

(fennec1.0+)

RESOLVED FIXED
fennec1.0
Tracking Status
fennec 1.0+ ---

People

(Reporter: mfinkle, Assigned: Gavin)

References

Details

Attachments

(1 file)

Mobile bookmarks should live in a virtual root:
* name is "Mobile" (localized)
* direct child of the main places root, not a child of one of the other roots
* has an annotation so it can be located quickly, regardless of l10n

Fennec will use this root as the parent for all bookmarks created in Fennec. Default bookmarks will also live in the root.
tracking-fennec: --- → ?
This could impact Weave too
Attached patch patchSplinter Review
Looks like it's as simple as this. JSON importer already allows creating bookmarks whose parent are the places root, so we just need to tweak the default bookmarks file accordingly. Will also need to talk to the weave folks about what this means for them.

Put the "mobileRoot" property on the BookmarkList object for easy access - kind of random, but couldn't think of a better place to put it.

Can't run the tests at the moment (Mac), so I just made obvious changes by inspection. I noticed some of them are obsoleted by e.g. bug 516958 so I guess they aren't currently passing?
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #411147 - Flags: review?(mark.finkle)
Comment on attachment 411147 [details] [diff] [review]
patch

Can we use  mobile/bookmarksRoot instead of fennec/bookmarksRoot for the annotation

r+ with that

Maybe we could add mobileRoot to PlaceUtils? The Weave team might find that useful too.
Attachment #411147 - Flags: review?(mark.finkle) → review+
tracking-fennec: ? → 1.0+
https://hg.mozilla.org/mobile-browser/rev/443a56ce5734
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Post-B5
Flags: in-litmus?
Flags: in-litmus? → in-litmus-
Component: General → Bookmarks
You need to log in before you can comment on or make changes to this bug.