525184 - Create a virtual places root for Mobile bookmarks

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Bookmarks, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Mobile bookmarks should live in a virtual root:
* name is "Mobile" (localized)
* direct child of the main places root, not a child of one of the other roots
* has an annotation so it can be located quickly, regardless of l10n

Fennec will use this root as the parent for all bookmarks created in Fennec. Default bookmarks will also live in the root.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

This could impact Weave too

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Looks like it's as simple as this. JSON importer already allows creating bookmarks whose parent are the places root, so we just need to tweak the default bookmarks file accordingly. Will also need to talk to the weave folks about what this means for them.

Put the "mobileRoot" property on the BookmarkList object for easy access - kind of random, but couldn't think of a better place to put it.

Can't run the tests at the moment (Mac), so I just made obvious changes by inspection. I noticed some of them are obsoleted by e.g. bug 516958 so I guess they aren't currently passing?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 411147 [details] [diff] [review]
patch

Can we use  mobile/bookmarksRoot instead of fennec/bookmarksRoot for the annotation

r+ with that

Maybe we could add mobileRoot to PlaceUtils? The Weave team might find that useful too.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mobile-browser/rev/443a56ce5734